Bug 91988 - [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
Summary: [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luciano Wolf
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2012-07-23 06:32 PDT by Caio Marcelo de Oliveira Filho
Modified: 2012-09-11 08:12 PDT (History)
2 users (show)

See Also:


Attachments
Fix TAB problem setting QKeyEvent keyText value (3.02 KB, patch)
2012-09-10 14:21 PDT, Luciano Wolf
no flags Details | Formatted Diff | Diff
Updated patch - after Caio's review (2.95 KB, patch)
2012-09-10 15:00 PDT, Luciano Wolf
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2012-07-23 06:32:47 PDT
The TABs are not being added in the result. I didn't investigate it deeply, but it could be a problem with out eventSender.keyDown implementation for WK2.
Comment 1 Luciano Wolf 2012-09-10 14:21:28 PDT
Created attachment 163208 [details]
Fix TAB problem setting QKeyEvent keyText value
Comment 2 Caio Marcelo de Oliveira Filho 2012-09-10 14:45:04 PDT
Comment on attachment 163208 [details]
Fix TAB problem setting QKeyEvent keyText value

View in context: https://bugs.webkit.org/attachment.cgi?id=163208&action=review

Nice fixing that :)

> Tools/ChangeLog:10
> +        QKeyEvent must have keyText information. Doing an experiment with QWidget
> +        and intercepting it's keyPress event it's possible to notice that TAB key
> +        returns a keyCode (Qt::Key_Tab) + a keyText ("\t").

You can omit your experiment, and add that "Regular key events generated by Qt for the tab key fill both keyCode and keyText, so we should do the same for our fake events."

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:134
> +            keyText = QString("\t");

Should we use QStringLiteral here? :-) http://woboq.com/blog/qstringliteral.html
Comment 3 Luciano Wolf 2012-09-10 15:00:23 PDT
Created attachment 163217 [details]
Updated patch - after Caio's review
Comment 4 WebKit Review Bot 2012-09-11 08:12:06 PDT
Comment on attachment 163217 [details]
Updated patch - after Caio's review

Clearing flags on attachment: 163217

Committed r128189: <http://trac.webkit.org/changeset/128189>
Comment 5 WebKit Review Bot 2012-09-11 08:12:09 PDT
All reviewed patches have been landed.  Closing bug.