NEW 91972
Add an overload for UChar* to StringTypeAdapter 
https://bugs.webkit.org/show_bug.cgi?id=91972
Summary Add an overload for UChar* to StringTypeAdapter
Patrick R. Gansterer
Reported 2012-07-23 01:57:03 PDT
Add an overload for UChar* to StringTypeAdapter
Attachments
Patch (1.58 KB, patch)
2012-07-23 01:58 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (3.36 KB, patch)
2012-07-23 11:36 PDT, Patrick R. Gansterer 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-07-23 01:58:54 PDT
Created attachment 153755 [details] Patch
Alexey Proskuryakov
Comment 2 2012-07-23 09:29:26 PDT
Why copy/paste the code?
Patrick R. Gansterer
Comment 3 2012-07-23 11:36:01 PDT
Created attachment 153823 [details] Patch
Alexey Proskuryakov
Comment 4 2012-07-23 14:13:37 PDT
Comment on attachment 153823 [details] Patch No copy/pasting is good. Please consider using std::remove_cv, and also explain why exactly this is needed now.
Patrick R. Gansterer
Comment 5 2012-07-23 15:01:58 PDT
(In reply to comment #4) > (From update of attachment 153823 [details]) > Please consider using std::remove_cv. I do not see a way how I can use it in this case without introducing additional classes. > also explain why exactly this is needed now. It's not needed now, but during working on some other stuff I had problems when using UChar arrays with this class, because of the missing overload. IMHO this is nothing for the ChangelLog. ;-)
Note You need to log in before you can comment on or make changes to this bug.