Bug 91972 - Add an overload for UChar* to StringTypeAdapter
Summary: Add an overload for UChar* to StringTypeAdapter
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-23 01:57 PDT by Patrick R. Gansterer
Modified: 2022-02-28 03:46 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2012-07-23 01:58 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (3.36 KB, patch)
2012-07-23 11:36 PDT, Patrick R. Gansterer 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-23 01:57:03 PDT 
Add an overload for UChar* to StringTypeAdapter
Comment 1 Patrick R. Gansterer 2012-07-23 01:58:54 PDT 
Created attachment 153755 [details]
Patch
Comment 2 Alexey Proskuryakov 2012-07-23 09:29:26 PDT 
Why copy/paste the code?
Comment 3 Patrick R. Gansterer 2012-07-23 11:36:01 PDT 
Created attachment 153823 [details]
Patch
Comment 4 Alexey Proskuryakov 2012-07-23 14:13:37 PDT 
Comment on attachment 153823 [details]
Patch

No copy/pasting is good. Please consider using std::remove_cv, and also explain why exactly this is needed now.
Comment 5 Patrick R. Gansterer 2012-07-23 15:01:58 PDT 
(In reply to comment #4)
> (From update of attachment 153823 [details])
> Please consider using std::remove_cv.
I do not see a way how I can use it in this case without introducing additional classes. 

> also explain why exactly this is needed now.
It's not needed now, but during working on some other stuff I had problems when using UChar arrays with this class, because of the missing overload. IMHO this is nothing for the ChangelLog. ;-)