Bug 91968 - [Qt] new test introduced in r120354 fails on Qt
Summary: [Qt] new test introduced in r120354 fails on Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 87008
  Show dependency tree / graph
 
Reported: 2012-07-23 00:57 PDT by Kristóf Kosztyó
Modified: 2012-10-08 12:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.21 KB, patch)
2012-10-04 13:21 PDT, Tullio Lucena 		kenneth: review+
Details | Formatted Diff | Diff
Patch (1.21 KB, patch)
2012-10-08 11:33 PDT, Tullio Lucena 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kristóf Kosztyó 2012-07-23 00:57:23 PDT 
fast/sub-pixel/table-rows-have-stable-height.html

--- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/sub-pixel/table-rows-have-stable-height-expected.txt 
+++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/sub-pixel/table-rows-have-stable-height-actual.txt 
@@ -1,13 +1,14 @@
-PASS At 50% zoom all heights matched.
-PASS At 75% zoom all heights matched.
-PASS At 90% zoom all heights matched.
-PASS At 110% zoom all heights matched.
-PASS At 125% zoom all heights matched.
-PASS At 133% zoom all heights matched.
-PASS At 150% zoom all heights matched.
-PASS At 175% zoom all heights matched.
-PASS At 200% zoom all heights matched.
-PASS At 100% zoom all heights matched.
+CONSOLE MESSAGE: line 91: TypeError: 'null' is not an object
+style.height	rect.height	rect.bottom - rect.top
+22	22	c
+a	b	c
+a	b	c
+a	b	c
+a	b	c
+a	b	c
+a	b	c
+a	b	c
+a	b	c
 This tests whether table row heights are stable by measuring the height of a row, assigning that height to another row and then measuring it. For each row the numbers in the three cells should be the same.
 
 Bug 88813
Comment 1 Ryosuke Niwa 2012-07-23 01:18:13 PDT 
I don't think this is anything to do with https://bugs.webkit.org/show_bug.cgi?id=91335.
Comment 2 Ryosuke Niwa 2012-07-23 01:19:12 PDT 
It must be http://trac.webkit.org/changeset/120354 instead.
Comment 3 Tullio Lucena 2012-10-04 13:21:42 PDT 
Created attachment 167163 [details]
Patch

Unskipping test that is passing.
Comment 4 WebKit Review Bot 2012-10-04 16:59:30 PDT 
Comment on attachment 167163 [details]
Patch

Rejecting attachment 167163 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
51>At revision 154708.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14152719
Comment 5 Tullio Lucena 2012-10-08 11:33:54 PDT 
Created attachment 167572 [details]
Patch

Updating the patch
Comment 6 WebKit Review Bot 2012-10-08 12:48:00 PDT 
Comment on attachment 167572 [details]
Patch

Clearing flags on attachment: 167572

Committed r130675: <http://trac.webkit.org/changeset/130675>
Comment 7 WebKit Review Bot 2012-10-08 12:48:03 PDT 
All reviewed patches have been landed.  Closing bug.