Bug 91963 - Null-pointer crash when parsing border-image
Summary: Null-pointer crash when parsing border-image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dstockwell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-22 23:57 PDT by dstockwell
Modified: 2012-07-23 17:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.02 KB, patch)
2012-07-22 23:59 PDT, dstockwell 		no flags Details | Formatted Diff | Diff
Patch (2.89 KB, patch)
2012-07-23 16:18 PDT, dstockwell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dstockwell 2012-07-22 23:57:44 PDT 
Null-pointer crash when parsing border-image
Comment 1 dstockwell 2012-07-22 23:59:19 PDT 
Created attachment 153741 [details]
Patch
Comment 2 Alexis Menard (darktears) 2012-07-23 04:42:04 PDT 
Comment on attachment 153741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review

> LayoutTests/ChangeLog:8
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

The changelog is wrong here.

> LayoutTests/fast/css/border-image-fill-crash.html:7
> +    testRunner.dumpAsText();

You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html
Comment 3 dstockwell 2012-07-23 16:18:44 PDT 
Created attachment 153891 [details]
Patch
Comment 4 dstockwell 2012-07-23 16:23:35 PDT 
(In reply to comment #2)
> (From update of attachment 153741 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review
> 
> > LayoutTests/ChangeLog:8
> > +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> The changelog is wrong here.

OOPS! Fixed.
 
> > LayoutTests/fast/css/border-image-fill-crash.html:7
> > +    testRunner.dumpAsText();
> 
> You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html

I can see how this might be helpful for a JavaScript based test, but in this case I think it would just make the test harder to read, what do you think?
Comment 5 WebKit Review Bot 2012-07-23 17:06:42 PDT 
Comment on attachment 153891 [details]
Patch

Clearing flags on attachment: 153891

Committed r123406: <http://trac.webkit.org/changeset/123406>
Comment 6 WebKit Review Bot 2012-07-23 17:06:46 PDT 
All reviewed patches have been landed.  Closing bug.