There are many attributes for fileChooser. And we need to use capture attribute to implement HTML media capture on the EFL. But we can not use that, because function prototype is like below. - Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Eina_Bool allows_multiple_files, Eina_List *accept_types, Eina_List **selected_filenames); We can used only two attributes with this prototype.(allows_multiple_files and accept_types) Therefore I think we need to change this prototype to like this. - Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser_Settings *settings, Eina_List **selected_filenames);
Created attachment 154315 [details] Patch
Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review > Source/WebKit/efl/ChangeLog:10 > + i.e., change "Eina_Bool allows_multiple_files, Eina_List *accpet_types" Nit: s/accpet/accept/ > Source/WebKit/efl/ewk/ewk_view.h:191 > - Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Eina_Bool allows_multiple_files, Eina_List *accept_types, Eina_List **selected_filenames); > + Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser *file_chooser, Eina_List **selected_filenames); Whenever you change this public smart class you must update EWK_VIEW_SMART_CLASS_VERSION below.
Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review > Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:487 > filenames.append((char*)filename); I know this is not related to your patch but since you're touching this part of the code: We should probably use here: filenames.append(String::fromUTF8(static_cast<char*>(filename)));
Comment on attachment 154315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review >> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:487 >> filenames.append((char*)filename); > > I know this is not related to your patch but since you're touching this part of the code: > We should probably use here: filenames.append(String::fromUTF8(static_cast<char*>(filename))); OK, I will do that. >> Source/WebKit/efl/ewk/ewk_view.h:191 >> + Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser *file_chooser, Eina_List **selected_filenames); > > Whenever you change this public smart class you must update EWK_VIEW_SMART_CLASS_VERSION below. Done.
Created attachment 154816 [details] Patch
Comment on attachment 154816 [details] Patch Looks fine.
Comment on attachment 154816 [details] Patch rs=me
Comment on attachment 154816 [details] Patch Clearing flags on attachment: 154816 Committed r123847: <http://trac.webkit.org/changeset/123847>
All reviewed patches have been landed. Closing bug.