Bug 91948 - Move GregorianDateTime from JSC to WTF namespace
Summary: Move GregorianDateTime from JSC to WTF namespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-22 15:08 PDT by Patrick R. Gansterer
Modified: 2012-07-23 22:21 PDT (History)
7 users (show)

See Also:


Attachments
Patch (59.64 KB, patch)
2012-07-22 15:17 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (63.87 KB, patch)
2012-07-22 15:41 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (67.32 KB, patch)
2012-07-22 23:30 PDT, Patrick R. Gansterer
ggaren: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-22 15:08:43 PDT
Move GregorianDateTime from JSC to WTF namespace
Comment 1 Patrick R. Gansterer 2012-07-22 15:17:05 PDT
Created attachment 153707 [details]
Patch
Comment 2 WebKit Review Bot 2012-07-22 15:20:48 PDT
Attachment 153707 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2012-07-22 15:29:23 PDT
Comment on attachment 153707 [details]
Patch

Attachment 153707 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13310877
Comment 4 Early Warning System Bot 2012-07-22 15:35:04 PDT
Comment on attachment 153707 [details]
Patch

Attachment 153707 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13318735
Comment 5 Patrick R. Gansterer 2012-07-22 15:41:24 PDT
Created attachment 153709 [details]
Patch
Comment 6 WebKit Review Bot 2012-07-22 15:43:35 PDT
Attachment 153709 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Early Warning System Bot 2012-07-22 15:57:44 PDT
Comment on attachment 153709 [details]
Patch

Attachment 153709 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13308916
Comment 8 Patrick R. Gansterer 2012-07-22 23:30:58 PDT
Created attachment 153737 [details]
Patch
Comment 9 WebKit Review Bot 2012-07-22 23:34:06 PDT
Attachment 153737 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/runtime/JSDateMath.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Geoffrey Garen 2012-07-23 16:42:51 PDT
Comment on attachment 153737 [details]
Patch

r=me
Comment 11 WebKit Review Bot 2012-07-23 16:58:09 PDT
Comment on attachment 153737 [details]
Patch

Rejecting attachment 153737 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ist.am
patching file Source/WTF/WTF.gypi
patching file Source/WTF/WTF.pro
patching file Source/WTF/WTF.xcodeproj/project.pbxproj
patching file Source/WTF/wtf/CMakeLists.txt
patching file Source/WTF/wtf/GregorianDateTime.h
patching file Source/WebCore/bridge/qt/qt_runtime.cpp
patching file Source/WebCore/bridge/qt/qt_runtime_qt4.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Geoffrey G..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13332164
Comment 12 Patrick R. Gansterer 2012-07-23 22:21:20 PDT
Committed r123425: <http://trac.webkit.org/changeset/123425>