WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91941
Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
https://bugs.webkit.org/show_bug.cgi?id=91941
Summary
Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and E...
Kent Tamura
Reported
2012-07-22 07:19:34 PDT
for consistency
Attachments
Patch
(89.94 KB, patch)
2012-07-22 08:00 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Patch 2
(90.79 KB, patch)
2012-07-22 08:25 PDT
,
Kent Tamura
haraken
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2012-07-22 08:00:04 PDT
Created
attachment 153690
[details]
Patch
Early Warning System Bot
Comment 2
2012-07-22 08:21:09 PDT
Comment on
attachment 153690
[details]
Patch
Attachment 153690
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/13311857
Kent Tamura
Comment 3
2012-07-22 08:25:08 PDT
Created
attachment 153691
[details]
Patch 2 Qt fix
Kentaro Hara
Comment 4
2012-07-22 15:15:52 PDT
Comment on
attachment 153691
[details]
Patch 2 View in context:
https://bugs.webkit.org/attachment.cgi?id=153691&action=review
> Source/WebCore/html/shadow/MeterShadowElement.h:87 > +#endif > #endif
If there are two or more #endif s, we want to put '#endif // METER_ELEMENT' and '#endif // MeterShadowElement_h'.
> Source/WebCore/html/shadow/ProgressShadowElement.h:88 > +#endif > #endif
Ditto.
> LayoutTests/fast/dom/wrapper-classes.html:281 > + // Conditional elements, VIDEO, PROGRESS_ELEMENT, RUBY, DATALIST_ELEMENT, METER_ELEMENT.
Nit: DATALIST => DATALIST_ELEMENT is intended? Looks good though.
Kent Tamura
Comment 5
2012-07-22 16:24:15 PDT
Committed
r123300
: <
http://trac.webkit.org/changeset/123300
>
Kent Tamura
Comment 6
2012-07-22 16:26:44 PDT
Comment on
attachment 153691
[details]
Patch 2 View in context:
https://bugs.webkit.org/attachment.cgi?id=153691&action=review
>> Source/WebCore/html/shadow/MeterShadowElement.h:87 >> #endif > > If there are two or more #endif s, we want to put '#endif // METER_ELEMENT' and '#endif // MeterShadowElement_h'.
Done.
>> Source/WebCore/html/shadow/ProgressShadowElement.h:88 >> #endif > > Ditto.
Done.
>> LayoutTests/fast/dom/wrapper-classes.html:281 >> + // Conditional elements, VIDEO, PROGRESS_ELEMENT, RUBY, DATALIST_ELEMENT, METER_ELEMENT. > > Nit: DATALIST => DATALIST_ELEMENT is intended? Looks good though.
Yes. We shouldn't add unrelated changes basically, however I think it's ok in this case because I'm modifying this line.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug