Bug 91939 – [CMake] Add option for ENABLE_DFG_JIT

• Status: REOPENED
• Component: Tools / Tests

[Patrick R. Gansterer]

[CMake] Add option for ENABLE_DFG_JIT

[Patrick R. Gansterer]

Created attachment 153689 [details]
Patch

[WebKit Review Bot]

Comment on attachment 153689 [details]
Patch

Clearing flags on attachment: 153689

Committed r123298: <http://trac.webkit.org/changeset/123298>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

Re-opened since this is blocked by 91953

[Daniel Bates]

(In reply to comment #2)
> [...]
> Committed r123298: <http://trac.webkit.org/changeset/123298>

This patch broke the Windows CE Release build:

<http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio>

[Daniel Bates]

(In reply to comment #5)
> (In reply to comment #2)
> > [...]
> > Committed r123298: <http://trac.webkit.org/changeset/123298>
> 
> This patch broke the Windows CE Release build:
> 
> <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio>

I committed an attempt to fix the build in <http://trac.webkit.org/changeset/123301> (see remark (*)). This broke the EFL Linux 64-bit Debug build [1] because the CMake defined ENABLE_DFG_JIT prevents us from evaluating the logic for enabling the ENABLE_DFG_JIT in wtf/Platorm.h [2]. 

From talking with Ryuan Choi on IRC this evening, we thought it was best to rollout this patch <http://trac.webkit.org/changeset/123303> (bug #91953) so that the intricacies between CMake and wtf/Platform.h can be worked out offline. It may also be beneficial to elaborate on the use case for exposing this option in CMake.

(*) I chose to disable the DFG JIT (by default) because I was unclear of both the state of JIT support in the Windows CE port (can we enable it in OptionsWinCE.cmake? [3]) and whether consensus was reached among other CMake-based port maintainers to enable the DFG JIT by default.

[1] <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/3131/steps/compile-webkit/logs/stdio>
[2] <http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h?rev=123181#L897>
[3] <http://trac.webkit.org/browser/trunk/Source/cmake/OptionsWinCE.cmake?rev=119767#L25>

[Patrick R. Gansterer]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > [...]
> > > Committed r123298: <http://trac.webkit.org/changeset/123298>
> > 
> > This patch broke the Windows CE Release build:
> > 
> > <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio>
> 
> I committed an attempt to fix the build in <http://trac.webkit.org/changeset/123301> (see remark (*)). This broke the EFL Linux 64-bit Debug build [1] because the CMake defined ENABLE_DFG_JIT prevents us from evaluating the logic for enabling the ENABLE_DFG_JIT in wtf/Platorm.h [2]. 
> 
> From talking with Ryuan Choi on IRC this evening, we thought it was best to rollout this patch <http://trac.webkit.org/changeset/123303> (bug #91953) so that the intricacies between CMake and wtf/Platform.h can be worked out offline. It may also be beneficial to elaborate on the use case for exposing this option in CMake.
> 
> (*) I chose to disable the DFG JIT (by default) because I was unclear of both the state of JIT support in the Windows CE port (can we enable it in OptionsWinCE.cmake? [3]) and whether consensus was reached among other CMake-based port maintainers to enable the DFG JIT by default.

I took the same on/off value as Platform.h declares. It's on for the EFL and Blackberry port all the time AFAICS. The build problem was caused, by the fact that ENABLE_DFG_JIT isn't guided with ENABLE_JIT to. Since we don't have any guideline when a CMake option is ok and when not I'd like to add it again with the corresponding off value for WinCE.
(I hate doing so much "feature detection" in Platform.h)