Bug 91938 - [WINCE] Define NOMINMAX in the build system instead of Platform.h
Summary: [WINCE] Define NOMINMAX in the build system instead of Platform.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-22 01:32 PDT by Patrick R. Gansterer
Modified: 2012-07-23 03:07 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.39 KB, patch)
2012-07-22 01:35 PDT, Patrick R. Gansterer
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-07-22 01:32:41 PDT
[WINCE] Define NOMINMAX in the build system instead of Platform.h
Comment 1 Patrick R. Gansterer 2012-07-22 01:35:57 PDT
Created attachment 153688 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-07-22 12:33:02 PDT
Comment on attachment 153688 [details]
Patch

LGTM from the build system side.
Comment 3 Ryosuke Niwa 2012-07-23 00:53:47 PDT
Comment on attachment 153688 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153688&action=review

> ChangeLog:8
> +        Define it OptionsWindows.cmake, since NOMINMAX

Nit: Define it in*.
Comment 4 Patrick R. Gansterer 2012-07-23 03:05:55 PDT
Committed r123324: <http://trac.webkit.org/changeset/123324>