Bug 91934 - Missing *explicit* keyword in storage and workers
Summary: Missing *explicit* keyword in storage and workers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-21 17:34 PDT by Gyuyoung Kim
Modified: 2012-07-22 18:28 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.73 KB, patch)
2012-07-21 17:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2012-07-21 17:34:19 PDT 
Some constructors missed to use *explicit* keyword. They need to be added *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion.
Comment 1 Gyuyoung Kim 2012-07-21 17:36:24 PDT 
Created attachment 153680 [details]
Patch
Comment 2 Kentaro Hara 2012-07-22 16:49:16 PDT 
Comment on attachment 153680 [details]
Patch

Good refactoring.
Comment 3 WebKit Review Bot 2012-07-22 18:27:55 PDT 
Comment on attachment 153680 [details]
Patch

Clearing flags on attachment: 153680

Committed r123305: <http://trac.webkit.org/changeset/123305>
Comment 4 WebKit Review Bot 2012-07-22 18:28:00 PDT 
All reviewed patches have been landed.  Closing bug.