Bug 91931 – Web Inspector: Redundant Style Declarations Missing in Styles Section

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Justin Lowery]

Created attachment 153673 [details]
Screenshot of problem.

Redundant CSS declarations are not showing up in Inspect Element panel. If you take a look at the included screenshot, you'll notice that *background: #bada55;* is not showing within the Styles section, but it does show in the Computed Style section. 

This is reproducible in WebKit nightly build and Chrome Canary by selecting any element that has a redundant declaration (you know, like a fallback for a CSS3 declaration) and inspecting it. You should notice the second declaration is missing in the Styles section. It does not occur in stable Safari or regular Chrome.

[Pavel Feldman]

Created attachment 153797 [details]
Patch

[Pavel Feldman]

Created attachment 153817 [details]
Patch

[Pavel Feldman]

Created attachment 154301 [details]
Patch

[Pavel Feldman]

Created attachment 154333 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 154301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154301&action=review

> Source/WebCore/inspector/InspectorCSSAgent.cpp:798
> +            CSSPropertyID longhandID = *(shorthand.properties() + j);

Please use [].

> Source/WebCore/inspector/InspectorStyleSheet.cpp:575
>          // else shorthandName is not set

Please remove this line and shorthandName.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1103
> +            // For style-based properties, try generating shorthands.

You already have a similar comment on line 1097

[Vsevolod Vlasov]

Comment on attachment 154333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=154333&action=review

> LayoutTests/inspector/styles/inject-stylesheet-expected.txt:-60
> -/-- overloaded --/ background: red;

Please make sure this is fixed before landing.

[Pavel Feldman]

Committed r123612: <http://trac.webkit.org/changeset/123612>