Bug 91928 - Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
Summary: Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 90846
  Show dependency treegraph
 
Reported: 2012-07-21 06:32 PDT by Kent Tamura
Modified: 2012-07-22 04:00 PDT (History)
9 users (show)

See Also:


Attachments
Patch (43.45 KB, patch)
2012-07-21 06:56 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-07-21 06:32:48 PDT
for consistency
Comment 1 Kent Tamura 2012-07-21 06:56:37 PDT
Created attachment 153669 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-21 22:55:49 PDT
Comment on attachment 153669 [details]
Patch

LGTM on CMAKE ports side.
Comment 3 Kentaro Hara 2012-07-22 02:06:38 PDT
Comment on attachment 153669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153669&action=review

Looks OK

> Source/WebCore/html/HTMLDetailsElement.idl:22
> +        Conditional=DETAILS_ELEMENT

Just a confirmation: You are intending to newly add this Conditional, right? Looks good to me.
Comment 4 Kent Tamura 2012-07-22 02:50:34 PDT
Comment on attachment 153669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153669&action=review

>> Source/WebCore/html/HTMLDetailsElement.idl:22
>> +        Conditional=DETAILS_ELEMENT
> 
> Just a confirmation: You are intending to newly add this Conditional, right? Looks good to me.

Right.
Comment 5 WebKit Review Bot 2012-07-22 03:59:53 PDT
Comment on attachment 153669 [details]
Patch

Clearing flags on attachment: 153669

Committed r123296: <http://trac.webkit.org/changeset/123296>
Comment 6 WebKit Review Bot 2012-07-22 04:00:00 PDT
All reviewed patches have been landed.  Closing bug.