RESOLVED FIXED 91928
Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT 
https://bugs.webkit.org/show_bug.cgi?id=91928
Summary Rename ENABLE_DETAILS to ENABLE_DETAILS_ELEMENT
Kent Tamura
Reported 2012-07-21 06:32:48 PDT
for consistency
Attachments
Patch (43.45 KB, patch)
2012-07-21 06:56 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2012-07-21 06:56:37 PDT
Created attachment 153669 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-21 22:55:49 PDT
Comment on attachment 153669 [details] Patch LGTM on CMAKE ports side.
Kentaro Hara
Comment 3 2012-07-22 02:06:38 PDT
Comment on attachment 153669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153669&action=review Looks OK > Source/WebCore/html/HTMLDetailsElement.idl:22 > + Conditional=DETAILS_ELEMENT Just a confirmation: You are intending to newly add this Conditional, right? Looks good to me.
Kent Tamura
Comment 4 2012-07-22 02:50:34 PDT
Comment on attachment 153669 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153669&action=review >> Source/WebCore/html/HTMLDetailsElement.idl:22 >> + Conditional=DETAILS_ELEMENT > > Just a confirmation: You are intending to newly add this Conditional, right? Looks good to me. Right.
WebKit Review Bot
Comment 5 2012-07-22 03:59:53 PDT
Comment on attachment 153669 [details] Patch Clearing flags on attachment: 153669 Committed r123296: <http://trac.webkit.org/changeset/123296>
WebKit Review Bot
Comment 6 2012-07-22 04:00:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.