Fix WebGL texSubImage2D for cube maps
Created attachment 153668 [details] Patch
Comment on attachment 153668 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153668&action=review Nice fix. r=me with one comment. Let me know if you want me to cq+ it as is. > Source/WebCore/html/canvas/WebGLRenderingContext.h:592 > + bool subImage2d); FYI, there's a preference in WebKit to use local enums instead of boolean arguments to avoid the problem of confusing "true, true, false" call sites. I don't think this is that big a deal here but just something to keep in mind. Here it could be enum { ForTexSubImage2D, NotForTexSubImage2D }.
Created attachment 153861 [details] Patch
changed to use enum instead of bool
Comment on attachment 153861 [details] Patch Thanks, nice. r=me
Comment on attachment 153861 [details] Patch Clearing flags on attachment: 153861 Committed r123395: <http://trac.webkit.org/changeset/123395>
All reviewed patches have been landed. Closing bug.