Bug 91927 - Fix WebGL texSubImage2D for cube maps
Summary: Fix WebGL texSubImage2D for cube maps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-21 04:00 PDT by Gregg Tavares
Modified: 2012-07-23 15:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.96 KB, patch)
2012-07-21 04:10 PDT, Gregg Tavares
no flags Details | Formatted Diff | Diff
Patch (19.14 KB, patch)
2012-07-23 14:29 PDT, Gregg Tavares
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-07-21 04:00:31 PDT
Fix WebGL texSubImage2D for cube maps
Comment 1 Gregg Tavares 2012-07-21 04:10:17 PDT
Created attachment 153668 [details]
Patch
Comment 2 Kenneth Russell 2012-07-23 11:05:51 PDT
Comment on attachment 153668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153668&action=review

Nice fix. r=me with one comment. Let me know if you want me to cq+ it as is.

> Source/WebCore/html/canvas/WebGLRenderingContext.h:592
> +                                   bool subImage2d);

FYI, there's a preference in WebKit to use local enums instead of boolean arguments to avoid the problem of confusing "true, true, false" call sites. I don't think this is that big a deal here but just something to keep in mind. Here it could be enum { ForTexSubImage2D, NotForTexSubImage2D }.
Comment 3 Gregg Tavares 2012-07-23 14:29:29 PDT
Created attachment 153861 [details]
Patch
Comment 4 Gregg Tavares 2012-07-23 14:30:15 PDT
changed to use enum instead of bool
Comment 5 Kenneth Russell 2012-07-23 14:54:45 PDT
Comment on attachment 153861 [details]
Patch

Thanks, nice. r=me
Comment 6 WebKit Review Bot 2012-07-23 15:53:44 PDT
Comment on attachment 153861 [details]
Patch

Clearing flags on attachment: 153861

Committed r123395: <http://trac.webkit.org/changeset/123395>
Comment 7 WebKit Review Bot 2012-07-23 15:53:47 PDT
All reviewed patches have been landed.  Closing bug.