RESOLVED FIXED 91921
[WIN] Remove ICU dependencies from UniscribeController 
https://bugs.webkit.org/show_bug.cgi?id=91921
Summary [WIN] Remove ICU dependencies from UniscribeController
Patrick R. Gansterer
Reported 2012-07-21 02:15:20 PDT
[WIN] Remove ICU dependencies from UniscribeController
Attachments
Patch (2.50 KB, patch)
2012-07-21 02:18 PDT, Patrick R. Gansterer 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2012-07-21 02:18:59 PDT
Created attachment 153662 [details] Patch
Ryosuke Niwa
Comment 2 2012-07-23 01:09:26 PDT
Comment on attachment 153662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153662&action=review > Source/WebCore/platform/graphics/win/UniscribeController.cpp:151 > + bool forceSmallCaps = isSmallCaps && (category(*curr) & (Mark_NonSpacing | Mark_Enclosing | Mark_SpacingCombining)); It's probably better to use c here instead of *curr.
Patrick R. Gansterer
Comment 3 2012-07-23 01:10:48 PDT
From http://icu-project.org/apiref/icu4c/uchar_8h.html #define U_GC_M_MASK (U_GC_MN_MASK|U_GC_ME_MASK|U_GC_MC_MASK) #define U_GC_MN_MASK U_MASK(U_NON_SPACING_MARK) #define U_GC_ME_MASK U_MASK(U_ENCLOSING_MARK) #define U_GC_MC_MASK U_MASK(U_COMBINING_SPACING_MARK)
Patrick R. Gansterer
Comment 4 2012-07-23 02:59:11 PDT
Committed r123323: <http://trac.webkit.org/changeset/123323>
Note You need to log in before you can comment on or make changes to this bug.