Bug 91918 - SVG-as-image (constrained) intrinsic size calculation is wrong in vertical writing modes
Summary: SVG-as-image (constrained) intrinsic size calculation is wrong in vertical wr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-07-20 22:28 PDT by mitz
Modified: 2012-07-21 14:55 PDT (History)
5 users (show)

See Also:


Attachments
Test case (510 bytes, text/html)
2012-07-20 22:28 PDT, mitz
no flags Details
Transpose the intrinsic size of the content renderer of a vertical replaced element to turn it from physical to logical (4.09 KB, patch)
2012-07-21 12:33 PDT, mitz
mitz: review-
Details | Formatted Diff | Diff
Another test case (438 bytes, text/html)
2012-07-21 13:52 PDT, mitz
no flags Details
Transpose the intrinsic size of the content renderer of a vertical replaced element to turn it from physical to logical (5.22 KB, patch)
2012-07-21 14:45 PDT, mitz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-07-20 22:28:04 PDT
Created attachment 153647 [details]
Test case

See the attached test case, which is a transposed version of svg/as-image/svg-intrinsic-size-rectangular.html . The image element should end up 100px wide and 200px tall, but RenderSVGRoot::computeIntrinsicRatioInformation() returns a physical intrinsic size (and ratio) instead of a logical size, which is what the caller expects (and what raster images return, so they work as expected).
Comment 1 mitz 2012-07-20 22:28:28 PDT
<rdar://problem/11928576>
Comment 2 mitz 2012-07-21 12:33:39 PDT
Created attachment 153674 [details]
Transpose the intrinsic size of the content renderer of a vertical replaced element to turn it from physical to logical
Comment 3 mitz 2012-07-21 13:52:30 PDT
Created attachment 153677 [details]
Another test case

Turns out this is not enough. The attached test case is still broken after applying attachment 153674 [details].
Comment 4 mitz 2012-07-21 14:45:32 PDT
Created attachment 153678 [details]
Transpose the intrinsic size of the content renderer of a vertical replaced element to turn it from physical to logical

Avoid clobbering m_intrinsicSize with a transposed value. Added a test for this, too.
Comment 5 mitz 2012-07-21 14:55:30 PDT
Fixed in r123294.