Bug 91917 - [chromium] Add more compositor unit tests for high DPI transforms
Summary: [chromium] Add more compositor unit tests for high DPI transforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks: 91417
  Show dependency tree / graph
 
Reported: 2012-07-20 21:32 PDT by Adrienne Walker
Modified: 2012-07-23 17:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.87 KB, patch)
2012-07-20 21:34 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Patch (10.64 KB, patch)
2012-07-20 22:07 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Fix egregious typo (10.75 KB, patch)
2012-07-20 23:53 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
More tests; fix scale for duplicateChild test (12.00 KB, patch)
2012-07-21 18:36 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Rebased to ToT (11.94 KB, patch)
2012-07-23 17:22 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Reorder expect calls (11.94 KB, patch)
2012-07-23 17:29 PDT, Adrienne Walker 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-07-20 21:32:49 PDT 
[chromium] Add more compositor unit tests for high DPI transforms
Comment 1 Adrienne Walker 2012-07-20 21:34:03 PDT 
Created attachment 153645 [details]
Patch
Comment 2 Adrienne Walker 2012-07-20 22:07:41 PDT 
Created attachment 153646 [details]
Patch
Comment 3 Adrienne Walker 2012-07-20 23:53:16 PDT 
Created attachment 153655 [details]
Fix egregious typo
Comment 4 Adrienne Walker 2012-07-21 18:36:23 PDT 
Created attachment 153681 [details]
More tests; fix scale for duplicateChild test
Comment 5 Adrienne Walker 2012-07-21 18:37:17 PDT 
Sorry for all the patch noise.  The previous patches had a bug in them that caused problems in dependent patches.  This is ready for review.
Comment 6 Dana Jansens 2012-07-23 14:04:53 PDT 
Comment on attachment 153681 [details]
More tests; fix scale for duplicateChild test

View in context: https://bugs.webkit.org/attachment.cgi?id=153681&action=review

nice tests! lgtm

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:3722
> +    EXPECT_TRANSFORMATION_MATRIX_EQ(parent->screenSpaceTransform(), expectedParentScreenSpaceTransform);

nit: expected value should come first in all these
Comment 7 vollick 2012-07-23 14:08:50 PDT 
Comment on attachment 153681 [details]
More tests; fix scale for duplicateChild test

Nice! LGTM, too.
Comment 8 Shawn Singh 2012-07-23 14:11:19 PDT 
Seems great to me too, but I did have one question - 

do you think we need to be testing more explicitly something about order of operations, just in case? it looks like we are implicitly testing order of operations between the scale and the layer position translation, but do we need to also check how the contents scale is ordered with respect to the compositeLayerTransform and compositeSublayerTransform?

I'm OK with the patch as-is, just wanted to throw that idea out there in case someone felt strongly.
Comment 9 Adrienne Walker 2012-07-23 17:22:43 PDT 
Created attachment 153911 [details]
Rebased to ToT
Comment 10 Adrienne Walker 2012-07-23 17:29:17 PDT 
Created attachment 153913 [details]
Reorder expect calls
Comment 11 Dana Jansens 2012-07-23 17:30:52 PDT 
Thanks for that. @kbr or @senorblanco for review?
Comment 12 Adrienne Walker 2012-07-23 17:32:30 PDT 
The diff from two patches ago is just to remove the clip rect line to rebase, one typo fix, and to reorder expect calls as Dana asked.
Comment 13 Kenneth Russell 2012-07-23 17:47:13 PDT 
Comment on attachment 153913 [details]
Reorder expect calls

rs=me based on Dana's review.
Comment 14 WebKit Review Bot 2012-07-23 17:57:38 PDT 
Comment on attachment 153913 [details]
Reorder expect calls

Clearing flags on attachment: 153913

Committed r123413: <http://trac.webkit.org/changeset/123413>
Comment 15 WebKit Review Bot 2012-07-23 17:57:42 PDT 
All reviewed patches have been landed.  Closing bug.