RESOLVED FIXED91914
[EFL] Remove unused headers from ewk_security_origin 
https://bugs.webkit.org/show_bug.cgi?id=91914
Summary [EFL] Remove unused headers from ewk_security_origin
Kihong Kwon
Reported 2012-07-20 18:16:56 PDT
There are some unused header in the ewk_security_origin.h/cpp We need to remove them.
Attachments
Patch (1.90 KB, patch)
2012-07-20 18:55 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (1.90 KB, patch)
2012-07-20 19:07 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-07-20 18:55:20 PDT
Created attachment 153638 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-20 19:02:37 PDT
Comment on attachment 153638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153638&action=review I don't think we can land any patchess without review except for gardening and urgent build break, crash problems > Source/WebKit/efl/ChangeLog:6 > + Unreviewed EFL gardening. This patch is not gardening.
Kihong Kwon
Comment 3 2012-07-20 19:07:04 PDT
Created attachment 153640 [details] Patch
Gyuyoung Kim
Comment 4 2012-07-20 19:08:52 PDT
Comment on attachment 153640 [details] Patch LGTM
Gyuyoung Kim
Comment 5 2012-07-20 19:11:17 PDT
Comment on attachment 153640 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153640&action=review > Source/WebKit/efl/ewk/ewk_security_origin.h:36 > +#include <Eina.h> It looks we don't need to move to .h file.
Gyuyoung Kim
Comment 6 2012-07-20 19:20:25 PDT
Comment on attachment 153640 [details] Patch Eina_List is being used by ewk_security_origin.h. It looks Eina.h files has included by include chain so far. So, there was a little misunderstanding. LGTM now.
Noam Rosenthal
Comment 7 2012-07-20 20:02:06 PDT
Comment on attachment 153640 [details] Patch rs=me
WebKit Review Bot
Comment 8 2012-07-20 20:58:42 PDT
Comment on attachment 153640 [details] Patch Clearing flags on attachment: 153640 Committed r123287: <http://trac.webkit.org/changeset/123287>
WebKit Review Bot
Comment 9 2012-07-20 20:58:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.