Bug 91901 - IndexedDB: Simplify backend interface classes
Summary: IndexedDB: Simplify backend interface classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 14:11 PDT by Joshua Bell
Modified: 2012-07-20 16:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (53.43 KB, patch)
2012-07-20 14:36 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2012-07-20 14:11:55 PDT 
IndexedDB: Simplify backend interface classes
Comment 1 Joshua Bell 2012-07-20 14:36:16 PDT 
Created attachment 153604 [details]
Patch
Comment 2 Joshua Bell 2012-07-20 14:40:23 PDT 
This patch gets the various IDBFooBackendImpl classes out of the business of using IDBFooBackendInterface* pointers except in implementations of the interface methods themselves, which reduces the surface area slightly.

Looking around, it seemed as though the static FooImpl* from(FooInterface*); pattern was used in WebCore for this purpose. tony@, any comments?
Comment 3 Tony Chang 2012-07-20 14:45:51 PDT 
Comment on attachment 153604 [details]
Patch

Seems fine.  It guess it reduces the interface size and means there are less virtual function calls so might be a bit faster.  If you guys all like this style, it's fine with me too.
Comment 4 David Grogan 2012-07-20 15:07:19 PDT 
LGTM
Comment 5 WebKit Review Bot 2012-07-20 16:55:18 PDT 
Comment on attachment 153604 [details]
Patch

Clearing flags on attachment: 153604

Committed r123276: <http://trac.webkit.org/changeset/123276>
Comment 6 WebKit Review Bot 2012-07-20 16:55:21 PDT 
All reviewed patches have been landed.  Closing bug.