RESOLVED FIXED 91901
IndexedDB: Simplify backend interface classes 
https://bugs.webkit.org/show_bug.cgi?id=91901
Summary IndexedDB: Simplify backend interface classes
Joshua Bell
Reported 2012-07-20 14:11:55 PDT
IndexedDB: Simplify backend interface classes
Attachments
Patch (53.43 KB, patch)
2012-07-20 14:36 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-07-20 14:36:16 PDT
Created attachment 153604 [details] Patch
Joshua Bell
Comment 2 2012-07-20 14:40:23 PDT
This patch gets the various IDBFooBackendImpl classes out of the business of using IDBFooBackendInterface* pointers except in implementations of the interface methods themselves, which reduces the surface area slightly. Looking around, it seemed as though the static FooImpl* from(FooInterface*); pattern was used in WebCore for this purpose. tony@, any comments?
Tony Chang
Comment 3 2012-07-20 14:45:51 PDT
Comment on attachment 153604 [details] Patch Seems fine. It guess it reduces the interface size and means there are less virtual function calls so might be a bit faster. If you guys all like this style, it's fine with me too.
David Grogan
Comment 4 2012-07-20 15:07:19 PDT
LGTM
WebKit Review Bot
Comment 5 2012-07-20 16:55:18 PDT
Comment on attachment 153604 [details] Patch Clearing flags on attachment: 153604 Committed r123276: <http://trac.webkit.org/changeset/123276>
WebKit Review Bot
Comment 6 2012-07-20 16:55:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.