Bug 91879 - [CSS Exclusions] Test incremental layout
Summary: [CSS Exclusions] Test incremental layout
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on: 89259
Blocks: 89256
  Show dependency treegraph
Reported: 2012-07-20 10:20 PDT by Bear Travis
Modified: 2012-09-12 10:32 PDT (History)
3 users (show)

See Also:

Adding tests (5.15 KB, patch)
2012-09-10 16:01 PDT, Bear Travis
jchaffraix: review+
Details | Formatted Diff | Diff
Updated patch (5.17 KB, patch)
2012-09-11 17:27 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-07-20 10:20:24 PDT
Split from bug 89259, per Alex's comments:
Can you also make a test where the text is changed dynamically? There's no code dealing with incremental layouts. I would add a bug for that and keep it in a different patch.
Comment 1 Bear Travis 2012-09-10 16:01:02 PDT
Created attachment 163240 [details]
Adding tests

Testing adding text and a shape-inside via javascript
Comment 2 Julien Chaffraix 2012-09-11 16:49:23 PDT
Comment on attachment 163240 [details]
Adding tests

View in context: https://bugs.webkit.org/attachment.cgi?id=163240&action=review

Nit: Maybe we should also test changing from one -webkit-shape-inside to another one?

> LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html:24
> +        This text should be contained by the blue square.

Don't forget to add a description of what you test. For example, here that dynamically setting -webkit-shape-inside properly relayout.
Comment 3 Bear Travis 2012-09-11 17:27:42 PDT
Created attachment 163487 [details]
Updated patch

Added descriptions to the bug, and filed bug 96451 to test changing between shapes once we have multiple shape-inside types working.
Comment 4 WebKit Review Bot 2012-09-12 10:32:14 PDT
Comment on attachment 163487 [details]
Updated patch

Clearing flags on attachment: 163487

Committed r128336: <http://trac.webkit.org/changeset/128336>
Comment 5 WebKit Review Bot 2012-09-12 10:32:17 PDT
All reviewed patches have been landed.  Closing bug.