Split from bug 89259, per Alex's comments: Can you also make a test where the text is changed dynamically? There's no code dealing with incremental layouts. I would add a bug for that and keep it in a different patch.
Created attachment 163240 [details] Adding tests Testing adding text and a shape-inside via javascript
Comment on attachment 163240 [details] Adding tests View in context: https://bugs.webkit.org/attachment.cgi?id=163240&action=review Nit: Maybe we should also test changing from one -webkit-shape-inside to another one? > LayoutTests/fast/exclusions/shape-inside/shape-inside-dynamic-shape-expected.html:24 > + This text should be contained by the blue square. Don't forget to add a description of what you test. For example, here that dynamically setting -webkit-shape-inside properly relayout.
Created attachment 163487 [details] Updated patch Added descriptions to the bug, and filed bug 96451 to test changing between shapes once we have multiple shape-inside types working.
Comment on attachment 163487 [details] Updated patch Clearing flags on attachment: 163487 Committed r128336: <http://trac.webkit.org/changeset/128336>
All reviewed patches have been landed. Closing bug.