Bug 91876 - Fix more -Wunused-private-field violations
Summary: Fix more -Wunused-private-field violations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 10:11 PDT by Nico Weber
Modified: 2012-07-20 11:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.67 KB, patch)
2012-07-20 10:13 PDT, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-07-20 10:11:46 PDT
Fix more -Wunused-private-field violations
Comment 1 Nico Weber 2012-07-20 10:13:08 PDT
Created attachment 153529 [details]
Patch
Comment 2 Adam Barth 2012-07-20 10:18:04 PDT
Comment on attachment 153529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153529&action=review

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:349
> -HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool reportErrors, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
> +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)

We should remove this argument from this function if its completely unused.
Comment 3 Nico Weber 2012-07-20 10:21:51 PDT
Comment on attachment 153529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153529&action=review

Thanks!

>> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:349
>> +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
> 
> We should remove this argument from this function if its completely unused.

There are several of those in WebKit. I plan to do a cleanup pass for these eventually.
Comment 4 WebKit Review Bot 2012-07-20 11:11:28 PDT
Comment on attachment 153529 [details]
Patch

Clearing flags on attachment: 153529

Committed r123239: <http://trac.webkit.org/changeset/123239>
Comment 5 WebKit Review Bot 2012-07-20 11:11:32 PDT
All reviewed patches have been landed.  Closing bug.