RESOLVED FIXED 91876
Fix more -Wunused-private-field violations 
https://bugs.webkit.org/show_bug.cgi?id=91876
Summary Fix more -Wunused-private-field violations
Nico Weber
Reported 2012-07-20 10:11:46 PDT
Fix more -Wunused-private-field violations
Attachments
Patch (10.67 KB, patch)
2012-07-20 10:13 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-07-20 10:13:08 PDT
Created attachment 153529 [details] Patch
Adam Barth
Comment 2 2012-07-20 10:18:04 PDT
Comment on attachment 153529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153529&action=review > Source/WebCore/html/parser/HTMLTreeBuilder.cpp:349 > -HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool reportErrors, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth) > +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth) We should remove this argument from this function if its completely unused.
Nico Weber
Comment 3 2012-07-20 10:21:51 PDT
Comment on attachment 153529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153529&action=review Thanks! >> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:349 >> +HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth) > > We should remove this argument from this function if its completely unused. There are several of those in WebKit. I plan to do a cleanup pass for these eventually.
WebKit Review Bot
Comment 4 2012-07-20 11:11:28 PDT
Comment on attachment 153529 [details] Patch Clearing flags on attachment: 153529 Committed r123239: <http://trac.webkit.org/changeset/123239>
WebKit Review Bot
Comment 5 2012-07-20 11:11:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.