Bug 91865 - [chromium] Enable the GPU-accelerated skia path for SVG lighting filters
Summary: [chromium] Enable the GPU-accelerated skia path for SVG lighting filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephen White
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 08:09 PDT by Stephen White
Modified: 2012-07-20 10:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.89 KB, patch)
2012-07-20 08:38 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Patch for landing (7.87 KB, patch)
2012-07-20 09:24 PDT, Stephen White 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-07-20 08:09:58 PDT 
[chromium] Enable the GPU-accelerated skia path for SVG lighting filters
Comment 1 Stephen White 2012-07-20 08:38:01 PDT 
Created attachment 153511 [details]
Patch
Comment 2 Dirk Schulze 2012-07-20 08:51:07 PDT 
Comment on attachment 153511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153511&action=review

LGTM. r=me.

> Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp:90
> +        if (!limitingConeAngle || limitingConeAngle > 90.0f || limitingConeAngle < -90.0f)

Omit the .0f every please. This is against style rules.
Comment 3 Stephen White 2012-07-20 09:24:56 PDT 
Created attachment 153522 [details]
Patch for landing
Comment 4 Stephen White 2012-07-20 09:26:06 PDT 
(In reply to comment #2)
> (From update of attachment 153511 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153511&action=review
> 
> LGTM. r=me.

Thanks for the review.

> > Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp:90
> > +        if (!limitingConeAngle || limitingConeAngle > 90.0f || limitingConeAngle < -90.0f)
> 
> Omit the .0f every please. This is against style rules.

Done in patch for landing.
Comment 5 WebKit Review Bot 2012-07-20 10:14:14 PDT 
Comment on attachment 153522 [details]
Patch for landing

Clearing flags on attachment: 153522

Committed r123225: <http://trac.webkit.org/changeset/123225>
Comment 6 WebKit Review Bot 2012-07-20 10:14:19 PDT 
All reviewed patches have been landed.  Closing bug.