91862 – Update text upon item selection for menu lists

ASSIGNED Bug 91862

Update text upon item selection for menu lists

https://bugs.webkit.org/show_bug.cgi?id=91862

Summary Update text upon item selection for menu lists

Pierre Rossi

Reported 2012-07-20 07:45:05 PDT

Update text upon item selection for menu lists

Attachments
Patch (1.79 KB, patch) 2012-07-24 04:03 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (11.16 KB, patch) 2013-01-22 08:38 PST, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (11.65 KB, patch) 2013-01-24 04:42 PST, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (12.36 KB, patch) 2013-01-24 07:47 PST, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (11.73 KB, patch) 2013-03-22 09:43 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (13.15 KB, patch) 2013-03-22 16:23 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (14.65 KB, patch) 2013-03-23 04:02 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64 (737.88 KB, application/zip) 2013-03-23 11:55 PDT, WebKit Review Bot	no flags	Details
Patch (15.13 KB, patch) 2013-03-26 02:04 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64 (1.11 MB, application/zip) 2013-03-26 03:13 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64 (925.65 KB, application/zip) 2013-03-26 03:56 PDT, WebKit Review Bot	no flags	Details
Patch (15.20 KB, patch) 2013-03-27 03:34 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Patch (15.10 KB, patch) 2013-03-27 07:16 PDT, Pierre Rossi	no flags	Details Formatted Diff Diff
Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 (797.17 KB, application/zip) 2013-03-27 08:12 PDT, WebKit Review Bot	no flags	Details
Patch (15.17 KB, patch) 2013-03-27 15:57 PDT, Pierre Rossi	beidson: review-	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2012-07-23 09:56:22 PDT

Can you please provide more information, e.g. a test case?

Pierre Rossi

Comment 2 2012-07-24 04:03:33 PDT

Created attachment 154012 [details] Patch

Pierre Rossi

Comment 3 2012-07-24 04:07:48 PDT

Comment on attachment 154012 [details] Patch @ap: I got somewhat sidetracked trying to look if that could be covered by a layout test. Here's the patch I had in mind, just to make the bug less cryptic for now.

Eric Seidel (no email)

Comment 4 2012-08-07 16:43:51 PDT

Comment on attachment 154012 [details] Patch I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process.

Benjamin Poulain

Comment 5 2013-01-11 23:57:34 PST

Comment on attachment 154012 [details] Patch (In reply to comment #4) > (From update of attachment 154012 [details]) > I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process. Agreed. Any reason why is setTextFromItem() not called from listBoxSelectItem? + How do we test this?

Pierre Rossi

Comment 6 2013-01-22 08:38:47 PST

Created attachment 183995 [details] Patch

Pierre Rossi

Comment 7 2013-01-22 08:47:50 PST

@Benjamin: Too hackish ? ;)(In reply to comment #5) > (From update of attachment 154012 [details]) > (In reply to comment #4) > > (From update of attachment 154012 [details] [details]) > > I would kinda have expected the DOM to call back to the renderer to set the text instead of the renderer driving the whole process. > > Agreed. Any reason why is setTextFromItem() not called from listBoxSelectItem? > Couldn't be bothered to expose one more function publicly I guess... > + How do we test this? What do you think ? Too hackish ?

kov's GTK+ EWS bot

Comment 8 2013-01-22 09:45:33 PST

Comment on attachment 183995 [details] Patch Attachment 183995 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/16035676

Build Bot

Comment 9 2013-01-22 09:53:46 PST

Comment on attachment 183995 [details] Patch Attachment 183995 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16031696

WebKit Review Bot

Comment 10 2013-01-22 10:03:12 PST

Comment on attachment 183995 [details] Patch Attachment 183995 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16045658 New failing tests: fast/hidpi/video-controls-in-hidpi.html fast/forms/select/option-selecting.html fast/dom/HTMLSelectElement/selected-false.html

Build Bot

Comment 11 2013-01-22 10:19:59 PST

Comment on attachment 183995 [details] Patch Attachment 183995 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16035692

Build Bot

Comment 12 2013-01-22 14:00:41 PST

Comment on attachment 183995 [details] Patch Attachment 183995 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16031831

Pierre Rossi

Comment 13 2013-01-24 04:42:29 PST

Created attachment 184464 [details] Patch

Build Bot

Comment 14 2013-01-24 05:21:40 PST

Comment on attachment 184464 [details] Patch Attachment 184464 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16080653

Build Bot

Comment 15 2013-01-24 05:32:22 PST

Comment on attachment 184464 [details] Patch Attachment 184464 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16110057

Pierre Rossi

Comment 16 2013-01-24 07:47:19 PST

Created attachment 184492 [details] Patch

Build Bot

Comment 17 2013-01-24 20:08:14 PST

Comment on attachment 184492 [details] Patch Attachment 184492 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16119065

Build Bot

Comment 18 2013-01-24 21:29:22 PST

Comment on attachment 184492 [details] Patch Attachment 184492 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16123067

Build Bot

Comment 19 2013-01-24 23:23:16 PST

Comment on attachment 184492 [details] Patch Attachment 184492 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/16124124

WebKit Review Bot

Comment 20 2013-01-25 01:57:51 PST

Comment on attachment 184492 [details] Patch Attachment 184492 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16117233 New failing tests: svg/W3C-SVG-1.1/types-basicDOM-01-b.svg

Pierre Rossi

Comment 21 2013-03-22 09:43:34 PDT

Created attachment 194573 [details] Patch

Pierre Rossi

Comment 22 2013-03-22 09:44:21 PDT

Attempt to make the gtk and win EWS smile again.

Pierre Rossi

Comment 23 2013-03-22 16:23:25 PDT

Created attachment 194651 [details] Patch

Build Bot

Comment 24 2013-03-23 02:25:11 PDT

Comment on attachment 194651 [details] Patch Attachment 194651 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17239475

Pierre Rossi

Comment 25 2013-03-23 04:02:22 PDT

Created attachment 194697 [details] Patch

WebKit Review Bot

Comment 26 2013-03-23 11:55:13 PDT

Comment on attachment 194697 [details] Patch Attachment 194697 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17250296 New failing tests: fast/forms/select/optgroup-rendering.html fast/forms/select/option-selecting.html fast/forms/select/menulist-multiple-text-update.html fast/forms/select/optgroup-clicking.html

WebKit Review Bot

Comment 27 2013-03-23 11:55:17 PDT

Created attachment 194713 [details] Archive of layout-test-results from gce-cr-linux-03 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-03 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Pierre Rossi

Comment 28 2013-03-26 02:04:56 PDT

Created attachment 195034 [details] Patch

WebKit Review Bot

Comment 29 2013-03-26 03:13:19 PDT

Comment on attachment 195034 [details] Patch Attachment 195034 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17337028 New failing tests: fast/forms/select/menulist-multiple-text-update.html

WebKit Review Bot

Comment 30 2013-03-26 03:13:23 PDT

Created attachment 195046 [details] Archive of layout-test-results from gce-cr-linux-08 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

WebKit Review Bot

Comment 31 2013-03-26 03:56:29 PDT

Comment on attachment 195034 [details] Patch Attachment 195034 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17246522 New failing tests: fast/forms/select/menulist-multiple-text-update.html

WebKit Review Bot

Comment 32 2013-03-26 03:56:35 PDT

Created attachment 195054 [details] Archive of layout-test-results from gce-cr-linux-01 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-01 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Pierre Rossi

Comment 33 2013-03-27 02:46:15 PDT

*** Bug 113045 has been marked as a duplicate of this bug. ***

Pierre Rossi

Comment 34 2013-03-27 03:34:35 PDT

Created attachment 195260 [details] Patch

WebKit Review Bot

Comment 35 2013-03-27 03:46:07 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17309388

Peter Beverloo (cr-android ews)

Comment 36 2013-03-27 03:49:02 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17314348

WebKit Review Bot

Comment 37 2013-03-27 04:03:14 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17314354

EFL EWS Bot

Comment 38 2013-03-27 04:14:33 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17330188

Build Bot

Comment 39 2013-03-27 04:21:38 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/17314362

Build Bot

Comment 40 2013-03-27 04:30:44 PDT

Comment on attachment 195260 [details] Patch Attachment 195260 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17299226

Pierre Rossi

Comment 41 2013-03-27 07:16:03 PDT

Created attachment 195312 [details] Patch

WebKit Review Bot

Comment 42 2013-03-27 08:12:29 PDT

Comment on attachment 195312 [details] Patch Attachment 195312 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17336129 New failing tests: fast/forms/select/menulist-multiple-text-update.html

WebKit Review Bot

Comment 43 2013-03-27 08:12:34 PDT

Created attachment 195327 [details] Archive of layout-test-results from gce-cr-linux-02 for chromium-linux-x86_64 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-02 Port: chromium-linux-x86_64 Platform: Linux-3.3.8-gcg-201212281604-x86_64-with-GCEL-10.04-gcel_10.04

Pierre Rossi

Comment 44 2013-03-27 15:57:50 PDT

Created attachment 195424 [details] Patch

Nick Monkman

Comment 45 2014-06-17 15:06:51 PDT

I'm seeing this behavior in Qt 5.3.0 on Linux and it is causing major headaches for my project. Any updates on this? Is the patch still awaiting review? I'm brand new to WebKit but I'm willing to help out however I can... Nick

Brady Eidson

Comment 46 2016-05-24 21:37:40 PDT

Comment on attachment 195424 [details] Patch r- to clear stale patches from the review queue

Note You need to log in before you can comment on or make changes to this bug.

Status ASSIGNED

Resolution

Priority P2

Severity Normal

Classification Unclassified

Version 528+ (Nightly build)

Hardware Unspecified

OS Unspecified

Product WebKit

Component Forms

Assignee

Pierre Rossi

Reported

2012-07-20 07:45 PDT

Modified

2016-05-24 21:37 PDT History

CC List

19 users Show

URL

Keywords

Duplicates (1)

113045 View as bug list

Depends on

Blocks

113045

Dependancies

tree graph