Bug 91857 - [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown
Summary: [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tommy Widenflycht
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 07:00 PDT by Tommy Widenflycht
Modified: 2012-07-23 09:15 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2012-07-20 07:03 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2012-07-20 07:20 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Patch (5.07 KB, patch)
2012-07-23 01:05 PDT, Tommy Widenflycht 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tommy Widenflycht 2012-07-20 07:00:59 PDT 
It caused valgrind issues.
Comment 1 Tommy Widenflycht 2012-07-20 07:03:26 PDT 
Created attachment 153497 [details]
Patch
Comment 2 Tommy Widenflycht 2012-07-20 07:20:42 PDT 
Created attachment 153501 [details]
Patch
Comment 3 WebKit Review Bot 2012-07-20 07:22:21 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adam Barth 2012-07-20 09:07:55 PDT 
Comment on attachment 153501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153501&action=review

> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:85
> +    OwnPtr<MockWebKitPlatformSupport> mockPlatform;

mockPlatform -> m_mockPlatform

> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:38
> -Platform* MockWebKitPlatformSupport::create()
> +MockWebKitPlatformSupport* MockWebKitPlatformSupport::create()

Should this return a PassOwnPtr?

> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:39
> +    ~MockWebKitPlatformSupport() { }

Please move this declaration out of line.
Comment 5 Tommy Widenflycht 2012-07-23 01:05:13 PDT 
Created attachment 153750 [details]
Patch
Comment 6 Tommy Widenflycht 2012-07-23 01:06:19 PDT 
Comment on attachment 153501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153501&action=review

>> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:85
>> +    OwnPtr<MockWebKitPlatformSupport> mockPlatform;
> 
> mockPlatform -> m_mockPlatform

Done.

>> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:38
>> +MockWebKitPlatformSupport* MockWebKitPlatformSupport::create()
> 
> Should this return a PassOwnPtr?

Yes, done.

>> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:39
>> +    ~MockWebKitPlatformSupport() { }
> 
> Please move this declaration out of line.

Done.
Comment 7 Adam Barth 2012-07-23 09:02:13 PDT 
Comment on attachment 153750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153750&action=review

> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:40
> -    return new MockWebKitPlatformSupport();
> +    return WTF::adoptPtr(new MockWebKitPlatformSupport());

I think the WTF:: here is optional.
Comment 8 WebKit Review Bot 2012-07-23 09:15:45 PDT 
Comment on attachment 153750 [details]
Patch

Clearing flags on attachment: 153750

Committed r123345: <http://trac.webkit.org/changeset/123345>
Comment 9 WebKit Review Bot 2012-07-23 09:15:50 PDT 
All reviewed patches have been landed.  Closing bug.