Bug 91847 - [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
Summary: [chromium] Don't include WebCore headers in TestInterfaces so it's safe to in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 03:00 PDT by jochen
Modified: 2012-07-20 11:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.60 KB, patch)
2012-07-20 03:07 PDT, jochen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-07-20 03:00:01 PDT
[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore
Comment 1 jochen 2012-07-20 03:07:02 PDT
Created attachment 153462 [details]
Patch
Comment 2 Adam Barth 2012-07-20 08:38:54 PDT
Comment on attachment 153462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review

> Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48
> +    class Internal;
> +    Internal* m_internal;

Isn't there an OwnPtr-like class we can use from the WebKit API?  WebPrivatePtr or something?
Comment 3 jochen 2012-07-20 10:59:25 PDT
(In reply to comment #2)
> (From update of attachment 153462 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48
> > +    class Internal;
> > +    Internal* m_internal;
> 
> Isn't there an OwnPtr-like class we can use from the WebKit API?  WebPrivatePtr or something?

Yes, but it would require defining WEBKIT_IMPLEMENTATION in TestInterfaces.cpp, and in contrast to OwnPtr, it doesn't destroy it's pointee automatically on destruction

I esp. don't like defining WEBKIT_IMPLEMENTATION, wdyt?
Comment 4 Adam Barth 2012-07-20 11:02:38 PDT
We don't want to define WEBKIT_IMPLEMENTATION since this library isn't part of webkit.dll.  Lets try your approach for now.  We might need to revise the approach in the future.
Comment 5 WebKit Review Bot 2012-07-20 11:13:33 PDT
Comment on attachment 153462 [details]
Patch

Clearing flags on attachment: 153462

Committed r123240: <http://trac.webkit.org/changeset/123240>
Comment 6 WebKit Review Bot 2012-07-20 11:13:37 PDT
All reviewed patches have been landed.  Closing bug.