Bug 91847 – [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore

Created attachment 153462 [details]
Patch

[Adam Barth]

Comment on attachment 153462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review

> Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48
> +    class Internal;
> +    Internal* m_internal;

Isn't there an OwnPtr-like class we can use from the WebKit API?  WebPrivatePtr or something?

(In reply to comment #2)
> (From update of attachment 153462 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review
> 
> > Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48
> > +    class Internal;
> > +    Internal* m_internal;
> 
> Isn't there an OwnPtr-like class we can use from the WebKit API?  WebPrivatePtr or something?

Yes, but it would require defining WEBKIT_IMPLEMENTATION in TestInterfaces.cpp, and in contrast to OwnPtr, it doesn't destroy it's pointee automatically on destruction

I esp. don't like defining WEBKIT_IMPLEMENTATION, wdyt?

[Adam Barth]

We don't want to define WEBKIT_IMPLEMENTATION since this library isn't part of webkit.dll.  Lets try your approach for now.  We might need to revise the approach in the future.

[WebKit Review Bot]

Comment on attachment 153462 [details]
Patch

Clearing flags on attachment: 153462

Committed r123240: <http://trac.webkit.org/changeset/123240>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.