Bug 91843 - [JSC] http/tests/security/cross-frame-access-put.html failing after r123145
Summary: [JSC] http/tests/security/cross-frame-access-put.html failing after r123145
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 02:38 PDT by Sudarsana Nagineni (babu)
Modified: 2012-09-17 05:48 PDT (History)
11 users (show)

See Also:

Attachments
Patch (133.66 KB, patch)
2012-09-17 00:12 PDT, Chris Dumez 		abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (135.63 KB, patch)
2012-09-17 04:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-07-20 02:38:58 PDT 
http/tests/security/cross-frame-access-put.html failing on EFL GTK and QT after r123145.

--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt
@@ -1,6 +1,4 @@
 CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html from frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html. Domains, protocols and ports must match.
-
-CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
 
 CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-put-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-put.html. Domains, protocols and ports must match.
Comment 1 Chris Dumez 2012-09-17 00:12:27 PDT 
Created attachment 164347 [details]
Patch
Comment 2 Adam Barth 2012-09-17 00:15:30 PDT 
Comment on attachment 164347 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-09-17 01:09:34 PDT 
Comment on attachment 164347 [details]
Patch

Attachment 164347 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13874321

New failing tests:
http/tests/security/cross-frame-access-put.html
Comment 4 Adam Barth 2012-09-17 02:27:38 PDT 
> http/tests/security/cross-frame-access-put.html

We probably need to update the V8 results as well.
Comment 5 Chris Dumez 2012-09-17 04:43:55 PDT 
Created attachment 164368 [details]
Patch

Attempt to fix Chromium EWS.
Comment 6 Chris Dumez 2012-09-17 05:19:18 PDT 
Comment on attachment 164368 [details]
Patch

Chromium EWS is now happy. Could someone please cq+ ?
Comment 7 WebKit Review Bot 2012-09-17 05:48:09 PDT 
Comment on attachment 164368 [details]
Patch

Clearing flags on attachment: 164368

Committed r128747: <http://trac.webkit.org/changeset/128747>
Comment 8 WebKit Review Bot 2012-09-17 05:48:13 PDT 
All reviewed patches have been landed.  Closing bug.