Bug 91833 - [EFL] Check parameters of ewk APIs in ewk_security_origin
Summary: [EFL] Check parameters of ewk APIs in ewk_security_origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-20 01:38 PDT by Kihong Kwon
Modified: 2012-07-20 04:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.77 KB, patch)
2012-07-20 02:30 PDT, Kihong Kwon 		no flags Details | Formatted Diff | Diff
Patch (5.55 KB, patch)
2012-07-20 03:52 PDT, Kihong Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kihong Kwon 2012-07-20 01:38:53 PDT 
For preventing crash, check parameter of ewk APIs in the ewk_security_origin.cpp.
Comment 1 Kihong Kwon 2012-07-20 02:30:36 PDT 
Created attachment 153455 [details]
Patch
Comment 2 Gyuyoung Kim 2012-07-20 02:45:58 PDT 
Comment on attachment 153455 [details]
Patch

Looks fine.
Comment 3 Chris Dumez 2012-07-20 03:14:21 PDT 
Comment on attachment 153455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153455&action=review

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:63
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);

You need to document this failure case return value in the header.

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:69
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);

Ditto.

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:80
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);

Ditto.

> Source/WebKit/efl/ewk/ewk_security_origin.cpp:112
> +    EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);

Ditto.
Comment 4 Kihong Kwon 2012-07-20 03:52:24 PDT 
Created attachment 153472 [details]
Patch
Comment 5 Kentaro Hara 2012-07-20 03:53:01 PDT 
Comment on attachment 153472 [details]
Patch

OK!
Comment 6 WebKit Review Bot 2012-07-20 04:27:02 PDT 
Comment on attachment 153472 [details]
Patch

Clearing flags on attachment: 153472

Committed r123202: <http://trac.webkit.org/changeset/123202>
Comment 7 WebKit Review Bot 2012-07-20 04:27:08 PDT 
All reviewed patches have been landed.  Closing bug.