RESOLVED FIXED 91833
[EFL] Check parameters of ewk APIs in ewk_security_origin 
https://bugs.webkit.org/show_bug.cgi?id=91833
Summary [EFL] Check parameters of ewk APIs in ewk_security_origin
Kihong Kwon
Reported 2012-07-20 01:38:53 PDT
For preventing crash, check parameter of ewk APIs in the ewk_security_origin.cpp.
Attachments
Patch (3.77 KB, patch)
2012-07-20 02:30 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Patch (5.55 KB, patch)
2012-07-20 03:52 PDT, Kihong Kwon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kihong Kwon
Comment 1 2012-07-20 02:30:36 PDT
Created attachment 153455 [details] Patch
Gyuyoung Kim
Comment 2 2012-07-20 02:45:58 PDT
Comment on attachment 153455 [details] Patch Looks fine.
Chris Dumez
Comment 3 2012-07-20 03:14:21 PDT
Comment on attachment 153455 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153455&action=review > Source/WebKit/efl/ewk/ewk_security_origin.cpp:63 > + EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0); You need to document this failure case return value in the header. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:69 > + EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0); Ditto. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:80 > + EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0); Ditto. > Source/WebKit/efl/ewk/ewk_security_origin.cpp:112 > + EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0); Ditto.
Kihong Kwon
Comment 4 2012-07-20 03:52:24 PDT
Created attachment 153472 [details] Patch
Kentaro Hara
Comment 5 2012-07-20 03:53:01 PDT
Comment on attachment 153472 [details] Patch OK!
WebKit Review Bot
Comment 6 2012-07-20 04:27:02 PDT
Comment on attachment 153472 [details] Patch Clearing flags on attachment: 153472 Committed r123202: <http://trac.webkit.org/changeset/123202>
WebKit Review Bot
Comment 7 2012-07-20 04:27:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.