[Chromium] Add WebView::zoomToFindInPageRect for Android
Created attachment 153380 [details] Patch
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Anyone care to review this patch? It's relatively straightforward.
Comment on attachment 153380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153380&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1087 > + double durationSec = isDoubleTap ? 0.25 : 0; Nit: Should we move .25 into a named constant? Also, durationSec -> durationSeconds
Comment on attachment 153380 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153380&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1076 > +void WebViewImpl::animateZoomAroundPoint(const IntPoint& point, AutoZoomType zoomType) nit: methods defined in the .cpp file should be listed in the same order as they appear in the .h file :-)
(In reply to comment #5) > (From update of attachment 153380 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153380&action=review > > > Source/WebKit/chromium/src/WebViewImpl.cpp:1076 > > +void WebViewImpl::animateZoomAroundPoint(const IntPoint& point, AutoZoomType zoomType) > > nit: methods defined in the .cpp file should be listed in the same order as they appear in the .h file :-) I was afraid you were going to say that. That's a big job for WebViewImpl.cpp. :) I've tried to put these diffs in the same location in the file as they exist in the chromium-android branch to make it easier for the folks doing the merges from trunk to the branch. I'll make you a deal: once we've unforked WebViewImpl.cpp, I'll fix the function ordering for the entire file.
Created attachment 153537 [details] Patch for landing
Comment on attachment 153537 [details] Patch for landing Clearing flags on attachment: 153537 Committed r123241: <http://trac.webkit.org/changeset/123241>
All reviewed patches have been landed. Closing bug.
(In reply to comment #6) > I'll make you a deal: once we've unforked WebViewImpl.cpp, I'll fix the function ordering for the entire file. OK, no worries.