Bug 91771 – create SourceBuffer and SourceBufferList objects

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Anna Cavender]

SourceBuffer and SourceBufferList objects are needed in order to implement the new object-oriented MediaSource API:
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#sourcebuffer
http://dvcs.w3.org/hg/html-media/raw-file/tip/media-source/media-source.html#sourcebufferlist

[Anna Cavender]

Created attachment 153333 [details]
Patch

[Build Bot]

Comment on attachment 153333 [details]
Patch

Attachment 153333 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13301083

[Anna Cavender]

Created attachment 153564 [details]
fix windows build files

[Anna Cavender]

Created attachment 153898 [details]
no diff, hoping win bot will run this time

[Eric Carlson]

Comment on attachment 153898 [details]
no diff, hoping win bot will run this time

View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59
> +    UNUSED_PARAM(data);
> +    // FIXME(91773): append the data to the media source.

Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter.

[Anna Cavender]

Comment on attachment 153898 [details]
no diff, hoping win bot will run this time

Thanks, Eric!

View in context: https://bugs.webkit.org/attachment.cgi?id=153898&action=review

>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:59
>> +    // FIXME(91773): append the data to the media source.
> 
> Nit: UNUSED_PARAM() isn't necessary if you don't name the parameter.

Gone.

[Anna Cavender]

Created attachment 154098 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 154098 [details]
Patch for landing

Clearing flags on attachment: 154098

Committed r123522: <http://trac.webkit.org/changeset/123522>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.