Bug 91760 - [CSS Exclusions] - Code cleanup: make shape parsing use isComma() instead of manual checks
Summary: [CSS Exclusions] - Code cleanup: make shape parsing use isComma() instead of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Trivial
Assignee: Bem Jones-Bey
URL: http://dev.w3.org/csswg/css3-exclusio...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-19 10:52 PDT by Bem Jones-Bey
Modified: 2012-07-19 12:32 PDT (History)
4 users (show)

See Also:

Attachments
Bug fix (2.16 KB, patch)
2012-07-19 11:56 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2012-07-19 10:52:06 PDT 
The CSSParser::parseExclusionShapePolygon method uses an isComma() function to detect a comma when parsing the argument list. The other shape parsing methods are not using this function. To reduce code duplication and make the code easier to read, those methods (CSSParser::parseExclusionShapeEllipse, CSSParser::parseExclusionShapeCircle, CSSParser::parseExclusionShapeRectangle) should use the isComma() function.
Comment 1 Bem Jones-Bey 2012-07-19 11:56:40 PDT 
Created attachment 153318 [details]
Bug fix

Change the aforementioned methods to use isComma.
Comment 2 Eric Seidel (no email) 2012-07-19 12:20:10 PDT 
Comment on attachment 153318 [details]
Bug fix

OK.
Comment 3 WebKit Review Bot 2012-07-19 12:32:40 PDT 
Comment on attachment 153318 [details]
Bug fix

Clearing flags on attachment: 153318

Committed r123135: <http://trac.webkit.org/changeset/123135>
Comment 4 WebKit Review Bot 2012-07-19 12:32:44 PDT 
All reviewed patches have been landed.  Closing bug.