RESOLVED FIXED 91757
Web Inspector: Status bar icons are misaligned by 1px to the right 
https://bugs.webkit.org/show_bug.cgi?id=91757
Summary Web Inspector: Status bar icons are misaligned by 1px to the right
dubroy
Reported 2012-07-19 10:03:27 PDT
Icons in the statusbar are shifted 1px to the right because they sprite assumes a 32px grid, but the button backgrounds are only 30px (with a 1px border). Also, the icons for dock-to-right, undock, etc. are an odd number of pixels wide, so they can't be perfectly centered.
Attachments
Patch (29.33 KB, patch)
2012-07-19 10:12 PDT, dubroy 		no flags
DetailsFormatted DiffDiff
Screenshot of old status bar, and result after applying the patch (12.72 KB, image/png)
2012-07-19 10:15 PDT, dubroy 		no flags
Details
Patch (1.42 KB, patch)
2012-07-19 10:39 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2012-07-19 10:49 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Glyphs with revised window docking icons (3.05 KB, image/png)
2012-07-19 12:33 PDT, dubroy 		no flags
Details
Patch (13.52 KB, patch)
2012-07-19 13:39 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[IMAGE] Screenshot with patch applied. (8.55 KB, image/png)
2012-07-19 13:57 PDT, Pavel Feldman 		no flags
Details
Revised glyphs with long-press indicator fixed (3.05 KB, image/png)
2012-07-19 14:13 PDT, dubroy 		no flags
Details
Patch (14.03 KB, patch)
2012-07-20 01:46 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
dubroy
Comment 1 2012-07-19 10:12:53 PDT
Created attachment 153290 [details] Patch
dubroy
Comment 2 2012-07-19 10:15:54 PDT
Created attachment 153293 [details] Screenshot of old status bar, and result after applying the patch
Pavel Feldman
Comment 3 2012-07-19 10:39:09 PDT
Created attachment 153298 [details] Patch
Pavel Feldman
Comment 4 2012-07-19 10:46:08 PDT
Historically, the glyphs were 32x24. It is just that migration from background images with painted border to the CSS borders shifted things. Shifting glyhs 1px should fix that.
Pavel Feldman
Comment 5 2012-07-19 10:49:46 PDT
Created attachment 153305 [details] Patch
dubroy
Comment 6 2012-07-19 11:52:22 PDT
Your patch will also reposition the .scripts-navigator-show-hide-button, etc. I'm not sure that we want to do that.
dubroy
Comment 7 2012-07-19 12:33:33 PDT
Created attachment 153321 [details] Glyphs with revised window docking icons Can you include the attached image in your patch? It reduces the width of the window docking icons by 1px, so that they have an even width and can be horizontally centered.
Pavel Feldman
Comment 8 2012-07-19 13:39:07 PDT
Created attachment 153337 [details] Patch
Pavel Feldman
Comment 9 2012-07-19 13:56:12 PDT
(In reply to comment #7) > Created an attachment (id=153321) [details] > Glyphs with revised window docking icons > > Can you include the attached image in your patch? It reduces the width of the window docking icons by 1px, so that they have an even width and can be horizontally centered. It looks good, but the long-press-indicator in the dock icon seems to be 1px off (touches the border). See the screenshot.
Pavel Feldman
Comment 10 2012-07-19 13:57:08 PDT
Created attachment 153340 [details] [IMAGE] Screenshot with patch applied.
dubroy
Comment 11 2012-07-19 14:13:25 PDT
Created attachment 153343 [details] Revised glyphs with long-press indicator fixed Whoops, I had assumed that was moving over 1px as well, since it did in my fix. New image attached.
Pavel Feldman
Comment 12 2012-07-20 01:46:56 PDT
Created attachment 153449 [details] Patch
Pavel Feldman
Comment 13 2012-07-20 06:08:18 PDT
Committed r123207: <http://trac.webkit.org/changeset/123207>
Note You need to log in before you can comment on or make changes to this bug.