RESOLVED FIXED 91744
Web Inspector: minimize number of properties on WebInspector.TimelinePresentationModel.Record
https://bugs.webkit.org/show_bug.cgi?id=91744
Summary Web Inspector: minimize number of properties on WebInspector.TimelinePresenta...
Andrey Kosyakov
Reported 2012-07-19 07:40:00 PDT
We create an instance of WebInspector.TimelinePresentationModel.Record for each timeline record. Most of the formatted record's fields so far are just copies of those on the low-level record. This change replaces those with getters, which reduces amount of space these records occupy nearly twice (11.7M => 6.77M for records, 9.3M => 7.3M for numbers).
Attachments
Patch (8.29 KB, patch)
2012-07-19 07:48 PDT, Andrey Kosyakov
pfeldman: review+
Andrey Kosyakov
Comment 1 2012-07-19 07:48:49 PDT
Pavel Feldman
Comment 2 2012-07-19 08:27:57 PDT
Comment on attachment 153263 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153263&action=review > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:391 > + this._style = WebInspector.TimelinePresentationModel.recordStyle(record); This could be done lazily. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:517 > + get category() Please annotate new members. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519 > + return this._style.category Inline _style here. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:524 > + return this.type === WebInspector.TimelineModel.RecordType.TimeStamp ? this._record.data["message"] : this._style.title; Inline _style here. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:562 > + get _selfTime() We never do private getters. > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:571 > + }, return null;
Andrey Kosyakov
Comment 3 2012-07-19 09:12:32 PDT
Note You need to log in before you can comment on or make changes to this bug.