Bug 91740 - WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED should be defined in Platform.h instead of wtf/Atomics.h
Summary: WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED should be defined in Platform.h instead...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-19 06:43 PDT by Wei James (wistoch)
Modified: 2012-07-19 09:17 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wei James (wistoch) 2012-07-19 06:43:03 PDT 
WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED is defined in wtf/Atomic.h, which should be in Platform.h
Comment 1 Alexey Proskuryakov 2012-07-19 09:07:20 PDT 
Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.
Comment 2 Wei James (wistoch) 2012-07-19 09:11:50 PDT 
(In reply to comment #1)
> Can you please provide the rationale? We have most USE macros defined in Platform.h indeed, but it's not great to dump them all together in one file. So, I'm honestly unsure if this would be an improvement.

see https://bugs.webkit.org/show_bug.cgi?id=89428#c16

there may be some misunderstanding in the bug #89428, peter asked me to put a MACRO in platform.h instead of Atomic.h. I misunderstood him and thought we shoudl put all MACRO in platform.h instead of Atomics.h. 

please ignore this bug entry. thanks