Bug 91736 – Use NSSliderCell to draw slider track

• Status: NEW
• Component: Forms

[Keishi Hattori]

Use NSSliderCell to draw slider track so we get the native look.

[Keishi Hattori]

Created attachment 153238 [details]
Patch

[Build Bot]

Comment on attachment 153238 [details]
Patch

Attachment 153238 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13284862

[Alexey Proskuryakov]

Comment on attachment 153238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153238&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:80
> +@interface SliderTrackCell : NSSliderCell

I think that all classes defined in WebKit should have a "Web" prefix.

> LayoutTests/ChangeLog:13
> +        * platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
> +        * platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
> +        * platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
> +        * platform/chromium-mac/fast/forms/range/input-appearance-range-expected.png:
> +        * platform/chromium-mac/fast/forms/range/slider-padding-expected.png:
> +        * platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.png:

How does this affect regular Mac results? I don't know if we ever got complaints about these controls looking non-native.

[Keishi Hattori]

Created attachment 153405 [details]
Patch

[Keishi Hattori]

Created attachment 153406 [details]
Screenshot

[Keishi Hattori]

Comment on attachment 153238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153238&action=review

>> Source/WebCore/rendering/RenderThemeMac.mm:80
>> +@interface SliderTrackCell : NSSliderCell
> 
> I think that all classes defined in WebKit should have a "Web" prefix.

Renamed to WebCoreSliderTrackCell.

>> LayoutTests/ChangeLog:13
>> +        * platform/chromium-mac/fast/forms/range/slider-thumb-shared-style-expected.png:
> 
> How does this affect regular Mac results? I don't know if we ever got complaints about these controls looking non-native.

Here is a screenshot in HiDPI mode comparing the before and after. The border, inner shadow, and background gradient are all different.
https://bug-91736-attachments.webkit.org/attachment.cgi?id=153406

[WebKit Review Bot]

Comment on attachment 153405 [details]
Patch

Attachment 153405 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13303203

New failing tests:
css3/filters/effect-opacity.html

[WebKit Review Bot]

Created attachment 153416 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Keishi Hattori]

Created attachment 153470 [details]
Patch

[Keishi Hattori]

Created attachment 153719 [details]
Patch

[Keishi Hattori]

Could someone review this? I have some patches that rely on this change. ap@ or jonlee@?

[Keishi Hattori]

To be more specific the upcoming patch will adjust the slider track position so we can draw an arrow slider knob for <input type=range> with <datalist>.

[Anders Carlsson]

Comment on attachment 153719 [details]
Patch

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.