Bug 91732 - Web Inspector: Drop "Loading..." message from FileContentView
Summary: Web Inspector: Drop "Loading..." message from FileContentView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Taiju Tsuiki
URL:
Keywords:
Depends on:
Blocks: 68203
  Show dependency tree / graph
 
Reported: 2012-07-19 04:35 PDT by Taiju Tsuiki
Modified: 2012-08-14 02:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2012-07-19 04:36 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2012-08-13 22:19 PDT, Taiju Tsuiki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Taiju Tsuiki 2012-07-19 04:35:05 PDT 
It seems better to show empty view while loading file.
Comment 1 Taiju Tsuiki 2012-07-19 04:36:17 PDT 
Created attachment 153227 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-07-20 02:53:51 PDT 
Comment on attachment 153227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review

> Source/WebCore/inspector/front-end/FileContentView.js:50
> +                this._innerView = new WebInspector.EmptyView(WebInspector.UIString(""));

this._innerView = new WebInspector.EmptyView("");
Comment 3 Taiju Tsuiki 2012-08-13 22:19:03 PDT 
Created attachment 158213 [details]
Patch
Comment 4 Taiju Tsuiki 2012-08-13 22:26:58 PDT 
Comment on attachment 153227 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review

>> Source/WebCore/inspector/front-end/FileContentView.js:50
>> +                this._innerView = new WebInspector.EmptyView(WebInspector.UIString(""));
> 
> this._innerView = new WebInspector.EmptyView("");

Done

I forgot to handle this...
Comment 5 WebKit Review Bot 2012-08-14 02:04:45 PDT 
Comment on attachment 158213 [details]
Patch

Clearing flags on attachment: 158213

Committed r125527: <http://trac.webkit.org/changeset/125527>
Comment 6 WebKit Review Bot 2012-08-14 02:04:50 PDT 
All reviewed patches have been landed.  Closing bug.