RESOLVED FIXED 91728
Web Inspector: Drag and drop should not be started on right mouse click. 
https://bugs.webkit.org/show_bug.cgi?id=91728
Summary Web Inspector: Drag and drop should not be started on right mouse click.
Vsevolod Vlasov
Reported 2012-07-19 03:17:56 PDT
Resizing drag and drop should not be started on right mouse click. This is currently happening in several places: SplitView, DataGrid.
Attachments
Patch (18.59 KB, patch)
2012-07-19 07:26 PDT, Vsevolod Vlasov 		no flags
DetailsFormatted DiffDiff
Patch (33.08 KB, patch)
2012-07-20 02:52 PDT, Vsevolod Vlasov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vsevolod Vlasov
Comment 1 2012-07-19 07:26:09 PDT
Created attachment 153257 [details] Patch
Pavel Feldman
Comment 2 2012-07-19 07:33:14 PDT
Comment on attachment 153257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153257&action=review > Source/WebCore/inspector/front-end/DataGrid.js:656 > + WebInspector.installDragStarter(resizer, this._startResizerDragging.bind(this)); DragHandle ? Could you instead pass all parameters into installDragHandle and get rid of elementDragStart?
Vsevolod Vlasov
Comment 3 2012-07-20 02:52:18 PDT
Created attachment 153457 [details] Patch
Pavel Feldman
Comment 4 2012-07-20 09:05:13 PDT
Comment on attachment 153457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153457&action=review > Source/WebCore/inspector/front-end/DataGrid.js:941 > + return true; Please annotate? return !!this._currentResizer.rightNeighboringColumnID;
Vsevolod Vlasov
Comment 5 2012-07-23 01:19:16 PDT
Committed r123313: <http://trac.webkit.org/changeset/123313>
Note You need to log in before you can comment on or make changes to this bug.