Bug 91728 - Web Inspector: Drag and drop should not be started on right mouse click.
Summary: Web Inspector: Drag and drop should not be started on right mouse click.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-19 03:17 PDT by Vsevolod Vlasov
Modified: 2012-07-23 01:19 PDT (History)
10 users (show)

See Also:

Attachments
Patch (18.59 KB, patch)
2012-07-19 07:26 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (33.08 KB, patch)
2012-07-20 02:52 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-07-19 03:17:56 PDT 
Resizing drag and drop should not be started on right mouse click.
This is currently happening in several places: SplitView, DataGrid.
Comment 1 Vsevolod Vlasov 2012-07-19 07:26:09 PDT 
Created attachment 153257 [details]
Patch
Comment 2 Pavel Feldman 2012-07-19 07:33:14 PDT 
Comment on attachment 153257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153257&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:656
> +                WebInspector.installDragStarter(resizer, this._startResizerDragging.bind(this));

DragHandle ?

Could you instead pass all parameters into installDragHandle and get rid of elementDragStart?
Comment 3 Vsevolod Vlasov 2012-07-20 02:52:18 PDT 
Created attachment 153457 [details]
Patch
Comment 4 Pavel Feldman 2012-07-20 09:05:13 PDT 
Comment on attachment 153457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153457&action=review

> Source/WebCore/inspector/front-end/DataGrid.js:941
> +        return true;

Please annotate?

return !!this._currentResizer.rightNeighboringColumnID;
Comment 5 Vsevolod Vlasov 2012-07-23 01:19:16 PDT 
Committed r123313: <http://trac.webkit.org/changeset/123313>