Bug 91726 - Update notifications to latest spec
Summary: Update notifications to latest spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.7
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks: 80472
  Show dependency treegraph
 
Reported: 2012-07-19 01:13 PDT by Jon Lee
Modified: 2012-09-10 15:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (21.79 KB, patch)
2012-07-20 13:28 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (20.42 KB, patch)
2012-09-07 17:08 PDT, Jon Lee
no flags Details | Formatted Diff | Diff
Patch (20.42 KB, patch)
2012-09-10 13:28 PDT, Jon Lee
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2012-07-19 01:13:29 PDT
1) Added "lang" attribute.
2) Remove event listeners from dictionary.
3) Rename "iconUrl" to "icon".
Comment 1 Radar WebKit Bug Importer 2012-07-19 01:13:52 PDT
<rdar://problem/11910451>
Comment 2 Jon Lee 2012-07-20 13:28:35 PDT
Created attachment 153583 [details]
Patch
Comment 3 Jon Lee 2012-09-07 16:53:45 PDT
Item 2) above was already covered in bug 95538.

But add a new item, which is to make the variables related to HTML notifications only available for legacy notifications.
Comment 4 Jon Lee 2012-09-07 17:08:11 PDT
Created attachment 162912 [details]
Patch
Comment 5 Jon Lee 2012-09-10 13:28:43 PDT
Created attachment 163194 [details]
Patch
Comment 6 Alexey Proskuryakov 2012-09-10 13:35:50 PDT
Comment on attachment 163194 [details]
Patch

OK. Abbrs make me unhappy.
Comment 7 Jon Lee 2012-09-10 15:12:23 PDT
Committed r128113: <http://trac.webkit.org/changeset/128113>