[Refactoring] Use userAgentShadowRoot() for elements having user agent shadow root.

[Shinya Kawanaka]

We have introduced Element::userAgentShadowRoot() for getting a user agent shadow root.
We often used shadow()->oldestShadowRoot() to take user agent shadow root, but we have to use userAgentShadowRoot() instead.
This will make our code intention clearer.

[Shinya Kawanaka]

grep 'oldestShadowRoot' -r Source/WebCore/html | wc
    30    126    3819

So, it's not so tough to covert them at once.

[Shinya Kawanaka]

Created attachment 153196 [details]
Patch

[Hajime Morrita]

Comment on attachment 153196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153196&action=review

> Source/WebCore/dom/ShadowRoot.cpp:146
> +    if (RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, host()->document()->documentElement(), AllowScriptingContent, ec))

How is this related to this change?

> Source/WebCore/html/HTMLImageElement.cpp:115
> +    if (ShadowRoot* userAgent = userAgentShadowRoot()) {

Could you consider the variable name? It's ridiculous to call it userAgent.

[Shinya Kawanaka]

> > Source/WebCore/dom/ShadowRoot.cpp:146
> > +    if (RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, host()->document()->documentElement(), AllowScriptingContent, ec))
> 
> How is this related to this change?

Oops... my experimental code was mixed...

[Shinya Kawanaka]

Created attachment 153204 [details]
Patch

[Shinya Kawanaka]

(In reply to comment #3)
> (From update of attachment 153196 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153196&action=review
> 
> > Source/WebCore/dom/ShadowRoot.cpp:146
> > +    if (RefPtr<DocumentFragment> fragment = createFragmentForInnerOuterHTML(markup, host()->document()->documentElement(), AllowScriptingContent, ec))
> 
> How is this related to this change?

--> removed.

> 
> > Source/WebCore/html/HTMLImageElement.cpp:115
> > +    if (ShadowRoot* userAgent = userAgentShadowRoot()) {
> 
> Could you consider the variable name? It's ridiculous to call it userAgent.

userAgent -> root

[WebKit Review Bot]

Comment on attachment 153204 [details]
Patch

Clearing flags on attachment: 153204

Committed r123082: <http://trac.webkit.org/changeset/123082>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.