RESOLVED FIXED 91715
CodeGeneratorV8.pm : @enabledAtRuntime is not used in GenerateHeader. 
https://bugs.webkit.org/show_bug.cgi?id=91715
Summary CodeGeneratorV8.pm : @enabledAtRuntime is not used in GenerateHeader.
Dongwoo Joshua Im (dwim)
Reported 2012-07-18 23:19:21 PDT
@enabledAtRuntime is not used in GenerateHeader. We can remove it from CodeGeneratorV8.pm. I'll upload a patch soon.
Attachments
Patch (2.25 KB, patch)
2012-07-18 23:32 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2012-07-18 23:50 PDT, Dongwoo Joshua Im (dwim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dongwoo Joshua Im (dwim)
Comment 1 2012-07-18 23:32:09 PDT
Created attachment 153185 [details] Patch
Kentaro Hara
Comment 2 2012-07-18 23:40:13 PDT
Comment on attachment 153185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review Looks good except for the copyright. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > +# Copyright (C) 2012 Samsung Electronics Normally WebKit doesn't add copyright for a simple change like this.
Dongwoo Joshua Im (dwim)
Comment 3 2012-07-18 23:48:42 PDT
(In reply to comment #2) > (From update of attachment 153185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review > > Looks good except for the copyright. > > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > > +# Copyright (C) 2012 Samsung Electronics > > Normally WebKit doesn't add copyright for a simple change like this. Oh. ok. no problem. ;) I usually implement a feature on port, so I put the copyright as a habit. If you want, I can re-upload the patch without the line.
Dongwoo Joshua Im (dwim)
Comment 4 2012-07-18 23:50:36 PDT
Created attachment 153190 [details] Patch
Kentaro Hara
Comment 5 2012-07-18 23:53:25 PDT
Comment on attachment 153190 [details] Patch OK. Please set "r?", then I can change it to "r+".
Kentaro Hara
Comment 6 2012-07-18 23:54:13 PDT
Also you can set "cq?" if you want to commit it, then I can change it to "cq+".
Dongwoo Joshua Im (dwim)
Comment 7 2012-07-19 00:02:08 PDT
(In reply to comment #6) > Also you can set "cq?" if you want to commit it, then I can change it to "cq+". I did! Actually, I was waiting the result of chromium ews. ;)
Kentaro Hara
Comment 8 2012-07-19 00:05:06 PDT
(In reply to comment #7) > Actually, I was waiting the result of chromium ews. ;) Basically you can set "r?" if you want to get feedback (without waiting the bot results). Also I can set "cq+" without waiting the bot results, since the commit queue will run the same tests before landing.
WebKit Review Bot
Comment 9 2012-07-19 00:29:59 PDT
Comment on attachment 153190 [details] Patch Clearing flags on attachment: 153190 Committed r123077: <http://trac.webkit.org/changeset/123077>
WebKit Review Bot
Comment 10 2012-07-19 00:30:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.