@enabledAtRuntime is not used in GenerateHeader. We can remove it from CodeGeneratorV8.pm. I'll upload a patch soon.
Created attachment 153185 [details] Patch
Comment on attachment 153185 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review Looks good except for the copyright. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > +# Copyright (C) 2012 Samsung Electronics Normally WebKit doesn't add copyright for a simple change like this.
(In reply to comment #2) > (From update of attachment 153185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review > > Looks good except for the copyright. > > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > > +# Copyright (C) 2012 Samsung Electronics > > Normally WebKit doesn't add copyright for a simple change like this. Oh. ok. no problem. ;) I usually implement a feature on port, so I put the copyright as a habit. If you want, I can re-upload the patch without the line.
Created attachment 153190 [details] Patch
Comment on attachment 153190 [details] Patch OK. Please set "r?", then I can change it to "r+".
Also you can set "cq?" if you want to commit it, then I can change it to "cq+".
(In reply to comment #6) > Also you can set "cq?" if you want to commit it, then I can change it to "cq+". I did! Actually, I was waiting the result of chromium ews. ;)
(In reply to comment #7) > Actually, I was waiting the result of chromium ews. ;) Basically you can set "r?" if you want to get feedback (without waiting the bot results). Also I can set "cq+" without waiting the bot results, since the commit queue will run the same tests before landing.
Comment on attachment 153190 [details] Patch Clearing flags on attachment: 153190 Committed r123077: <http://trac.webkit.org/changeset/123077>
All reviewed patches have been landed. Closing bug.