Bug 91714 – Web Inspector: Timeline: forward compatibility for load.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

Created attachment 153182 [details]
Demo screenshot

When you try to load timeline data with record types unknown in current version, exception occurs.

Fix: accept record of unrecognized types and render them as "unknown".

Created attachment 153184 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 153184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153184&action=review

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:66
> +        var recordTypes = WebInspector.TimelineModel.RecordType;

Maybe extract _initRecordStyles() ?

> LayoutTests/inspector/timeline/timeline-load-incompatible.html:43
> +Tests the Timeline save/load of unknown (incompatible) record types.

Please add a link to the bug below.

Comment on attachment 153184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153184&action=review

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:66
>> +        var recordTypes = WebInspector.TimelineModel.RecordType;
> 
> Maybe extract _initRecordStyles() ?

Done.

>> LayoutTests/inspector/timeline/timeline-load-incompatible.html:43
>> +Tests the Timeline save/load of unknown (incompatible) record types.
> 
> Please add a link to the bug below.

Done.

Created attachment 153217 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 153217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153217&action=review

> Source/WebCore/English.lproj/localizedStrings.js:219
> +localizedStrings["Unknown: "] = "Unknown: ";

Unknown: %s

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:115
> +            title: WebInspector.UIString("Unknown: ") + WebInspector.UIString(record.type),

So where would we get a UIString for unknown records? ;-)

Comment on attachment 153217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153217&action=review

>> Source/WebCore/English.lproj/localizedStrings.js:219
>> +localizedStrings["Unknown: "] = "Unknown: ";
> 
> Unknown: %s

Fixed.

>> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:115
>> +            title: WebInspector.UIString("Unknown: ") + WebInspector.UIString(record.type),
> 
> So where would we get a UIString for unknown records? ;-)

Hope never dies =)
Fixed.

Created attachment 153225 [details]
Patch

[Andrey Kosyakov]

Comment on attachment 153225 [details]
Patch

LGTM

[WebKit Review Bot]

Comment on attachment 153225 [details]
Patch

Clearing flags on attachment: 153225

Committed r123198: <http://trac.webkit.org/changeset/123198>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.