[chromium] Add histogram for tracking compositor-thread frame rate
Created attachment 153130 [details] Patch
Comment on attachment 153130 [details] Patch What's the histogram for non-threaded mode?
its in RenderWidget either Renderer4.AccelDoDeferredUpdateDelay or Software
Comment on attachment 153130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153130&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 60, 30); Isn't drawDelay in seconds?
Created attachment 153141 [details] Patch
Comment on attachment 153141 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153141&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 120, 60); Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better.
Created attachment 153143 [details] Patch
(In reply to comment #6) > (From update of attachment 153141 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153141&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 120, 60); > > Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better. Same question applies to this latest patch.
> Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better. Hehe yep. I'm boosting the range on those in this changelist: http://codereview.chromium.org/10802026/ Reason is, on those, with 0-60, 20% of the samples clip out at >60ms. I'd like to know how far that goes.
Comment on attachment 153143 [details] Patch R=me.
Comment on attachment 153143 [details] Patch Clearing flags on attachment: 153143 Committed r123056: <http://trac.webkit.org/changeset/123056>
All reviewed patches have been landed. Closing bug.