This is for PR160619. The hole punch rectangle needs to be present if and only if html5 video content is being rendered. Otherwise unwanted content may show through from behind the browser tab's window.
Created attachment 153128 [details] Patch
Comment on attachment 153128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153128&action=review Good stuff Nit: comments in the code need period at the end. Please reupload with "Reviewed by Antonio Gomes" and only ask for commit-queue. No need to get it reviewed again. > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:512 > + // Remove media player from platform layer (removes hole punch rect) comments are real sentenses > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:525 > + // Create platform layer for video (creates hole punch rect) ditto
Created attachment 153315 [details] Patch
The only change in the latest patch is the addition of periods to the ends of comments, and setting "Antonio Gomes" as the reviewer in the changelog entry.
Comment on attachment 153315 [details] Patch Clearing flags on attachment: 153315 Committed r123138: <http://trac.webkit.org/changeset/123138>
All reviewed patches have been landed. Closing bug.
Closing bug for patch that landed a long time ago.