Bug 91689 - [BlackBerry] Only maintain the hole punch rect while html5 video is being renderered
Summary: [BlackBerry] Only maintain the hole punch rect while html5 video is being ren...
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Feil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 16:07 PDT by Max Feil
Modified: 2012-11-02 12:52 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.96 KB, patch)
2012-07-18 16:15 PDT, Max Feil
no flags Details | Formatted Diff | Diff
Patch (2.96 KB, patch)
2012-07-19 11:52 PDT, Max Feil
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Max Feil 2012-07-18 16:07:16 PDT
This is for PR160619. The hole punch rectangle needs to be present if and only if html5 video content is being rendered. Otherwise unwanted content may show through from behind the browser tab's window.
Comment 1 Max Feil 2012-07-18 16:15:28 PDT
Created attachment 153128 [details]
Patch
Comment 2 Antonio Gomes 2012-07-19 07:58:37 PDT
Comment on attachment 153128 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=153128&action=review

Good stuff

Nit: comments in the code need period at the end. Please reupload with "Reviewed by Antonio Gomes" and only ask for commit-queue. No need to get it reviewed again.

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:512
> +            // Remove media player from platform layer (removes hole punch rect)

comments are real sentenses

> Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:525
> +            // Create platform layer for video (creates hole punch rect)

ditto
Comment 3 Max Feil 2012-07-19 11:52:10 PDT
Created attachment 153315 [details]
Patch
Comment 4 Max Feil 2012-07-19 11:54:51 PDT
The only change in the latest patch is the addition of periods to the ends of comments, and setting "Antonio Gomes" as the reviewer in the changelog entry.
Comment 5 WebKit Review Bot 2012-07-19 12:49:01 PDT
Comment on attachment 153315 [details]
Patch

Clearing flags on attachment: 153315

Committed r123138: <http://trac.webkit.org/changeset/123138>
Comment 6 WebKit Review Bot 2012-07-19 12:49:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Max Feil 2012-11-02 12:50:53 PDT
Closing bug for patch that landed a long time ago.
Comment 8 Max Feil 2012-11-02 12:52:07 PDT
Closing bug for patch that landed a long time ago.