Bug 91662 – Prototype of media source time offset (not to be committed)

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Victoria Kirst]

Prototype of media source time offset (not to be committed)

[Victoria Kirst]

Reopening to attach new patch.

[Victoria Kirst]

Created attachment 153074 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Victoria Kirst]

Prototype code that's not meant for review.

Should be used in conjunction with the following chromium CL:
https://chromiumcodereview.appspot.com/10803019/

Prototyping an implementation of timestamp offset for MediaSource.

[Eric Carlson]

> Source/WebCore/ChangeLog:8
> +        Prototype of media source time offset (not to be committed)
> +        https://bugs.webkit.org/show_bug.cgi?id=91662
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).

What is motivating these changes? Where are the per-function descriptions?

> Source/WebCore/html/HTMLMediaElement.idl:106
> +    /// VRK's HACK !!!

What is this?

[Victoria Kirst]

(In reply to comment #5)
> > Source/WebCore/ChangeLog:8
> > +        Prototype of media source time offset (not to be committed)
> > +        https://bugs.webkit.org/show_bug.cgi?id=91662
> > +
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!).
> 
> What is motivating these changes? Where are the per-function descriptions?
> 
> > Source/WebCore/html/HTMLMediaElement.idl:106
> > +    /// VRK's HACK !!!
> 
> What is this?

Sorry Eric!! Didn't mean for this to be reviewed or committed - just wanted to show the CL to a teammate (acolwell@). I didn't realize it would auto-CC everyone and send a bunch of emails!

[Eric Carlson]

(In reply to comment #6)
> 
> Sorry Eric!! Didn't mean for this to be reviewed or committed - just wanted to show the CL to a teammate (acolwell@). I didn't realize it would auto-CC everyone and send a bunch of emails!

No worries! YOu might want to try the "show-pretty-diff" tools to create formatted diff files, I use it all the time when I want to send a WIP patch to someone via email.