Bug 91651 - [Chromium] Support external autofill popups
Summary: [Chromium] Support external autofill popups
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Blocks: 91648
  Show dependency treegraph
Reported: 2012-07-18 12:34 PDT by Peter Beverloo
Modified: 2012-07-19 16:27 PDT (History)
7 users (show)

See Also:

work in progress (2.10 KB, patch)
2012-07-19 13:43 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2012-07-19 14:38 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (3.22 KB, patch)
2012-07-19 15:07 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Beverloo 2012-07-18 12:34:18 PDT
This is used by Chromium for Android. The downstream patch' SHA is e8870ae.
Comment 1 Adam Barth 2012-07-19 12:52:12 PDT
To save other folks the research, I think what's left here is WebView::selectAutofillSuggestionAtIndex
Comment 2 Adam Barth 2012-07-19 13:43:55 PDT
Created attachment 153338 [details]
work in progress
Comment 3 Adam Barth 2012-07-19 14:38:55 PDT
Created attachment 153347 [details]
Comment 4 WebKit Review Bot 2012-07-19 14:45:13 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 5 Darin Fisher (:fishd, Google) 2012-07-19 14:50:56 PDT
Comment on attachment 153347 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=153347&action=review

> Source/WebKit/chromium/ChangeLog:8
> +        This looks like the last piece of needed to support external autofill

nit: "last piece [--of--] needed to support external"

> Source/WebKit/chromium/ChangeLog:9
> +        popups. This funtion just lets the embedder select an index (presumably

nit: funtion -> function
Comment 6 Adam Barth 2012-07-19 15:07:56 PDT
Created attachment 153359 [details]
Patch for landing
Comment 7 WebKit Review Bot 2012-07-19 16:27:49 PDT
Comment on attachment 153359 [details]
Patch for landing

Clearing flags on attachment: 153359

Committed r123160: <http://trac.webkit.org/changeset/123160>
Comment 8 WebKit Review Bot 2012-07-19 16:27:54 PDT
All reviewed patches have been landed.  Closing bug.