RESOLVED FIXED 91637
Roll out r121610 and r122487 which may have been causing flaky crashes
https://bugs.webkit.org/show_bug.cgi?id=91637
Summary Roll out r121610 and r122487 which may have been causing flaky crashes
Joshua Bell
Reported 2012-07-18 10:22:32 PDT
Roll out r121610 and r122487 which may have been causing flaky crashes
Attachments
Patch (40.91 KB, patch)
2012-07-18 10:52 PDT, Joshua Bell
haraken: review+
Joshua Bell
Comment 1 2012-07-18 10:30:33 PDT
I don't have strong evidence that r121610 is behind the flakes described in webkit.org/b/90469 but we should rule it out. Will upload a patch here once I've got a try run.
Joshua Bell
Comment 2 2012-07-18 10:52:08 PDT
Kentaro Hara
Comment 3 2012-07-18 10:55:20 PDT
Comment on attachment 153047 [details] Patch OK. Try it.
WebKit Review Bot
Comment 4 2012-07-18 10:58:14 PDT
Attachment 153047 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/plug..." exit_code: 1 Source/WebCore/bindings/v8/NPObjectWrapper.cpp:151: Place brace on its own line for function definitions. [whitespace/braces] [4] Source/WebCore/bindings/v8/NPObjectWrapper.cpp:176: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/bindings/v8/NPObjectWrapper.cpp:174: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Source/WebCore/bindings/v8/NPObjectWrapper.cpp:178: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/bindings/v8/ScriptController.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/v8/NPObjectWrapper.h:46: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:52: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:56: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:60: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:61: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:62: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:63: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:64: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:65: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:66: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:67: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:68: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:69: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:70: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:71: The parameter name "npp" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:71: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:71: Missing space after , [whitespace/comma] [3] Source/WebCore/bindings/v8/NPObjectWrapper.h:74: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/bindings/v8/NPObjectWrapper.h:78: The parameter name "obj" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 24 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kentaro Hara
Comment 5 2012-07-18 10:59:11 PDT
Maybe you need to land it manually to avoid style check errors.
Joshua Bell
Comment 6 2012-07-19 14:23:42 PDT
Landed manually as r123110: http://trac.webkit.org/changeset/123110 ... and looking promising. 0 of the 17 runs have shown flaky crashes in the "s*" layout tests after the patch landing, compared to a roughly 95% showing a flaky crash prior to that revision. Will give it a day before updating TestExpectations, though.
Note You need to log in before you can comment on or make changes to this bug.