RESOLVED FIXED91636
[Soup] Unnecessary RefPtr usage and null check 
https://bugs.webkit.org/show_bug.cgi?id=91636
Summary [Soup] Unnecessary RefPtr usage and null check
Gustavo Noronha (kov)
Reported 2012-07-18 10:17:23 PDT
[Soup] Unnecessary RefPtr usage and null check
Attachments
Patch (1.78 KB, patch)
2012-07-18 10:22 PDT, Gustavo Noronha (kov) 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2012-07-18 10:22:05 PDT
Created attachment 153037 [details] Patch
Martin Robinson
Comment 2 2012-07-18 22:13:27 PDT
Comment on attachment 153037 [details] Patch Hrm. Why is the check unnecessary? The comment seems to suggest otherwise?
Gustavo Noronha (kov)
Comment 3 2012-07-19 05:28:15 PDT
Well, the function ends just after the check, so there's nothing else it could be doing other than return either way =)
Martin Robinson
Comment 4 2012-07-19 11:54:45 PDT
Comment on attachment 153037 [details] Patch Good point!
Gustavo Noronha (kov)
Comment 5 2012-07-20 14:41:31 PDT
Committed r123265: <http://trac.webkit.org/changeset/123265>
Note You need to log in before you can comment on or make changes to this bug.