Bug 91636 - [Soup] Unnecessary RefPtr usage and null check
Summary: [Soup] Unnecessary RefPtr usage and null check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-18 10:17 PDT by Gustavo Noronha (kov)
Modified: 2012-07-20 14:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2012-07-18 10:22 PDT, Gustavo Noronha (kov) 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-07-18 10:17:23 PDT 
[Soup] Unnecessary RefPtr usage and null check
Comment 1 Gustavo Noronha (kov) 2012-07-18 10:22:05 PDT 
Created attachment 153037 [details]
Patch
Comment 2 Martin Robinson 2012-07-18 22:13:27 PDT 
Comment on attachment 153037 [details]
Patch

Hrm. Why is the check unnecessary? The comment seems to suggest otherwise?
Comment 3 Gustavo Noronha (kov) 2012-07-19 05:28:15 PDT 
Well, the function ends just after the check, so there's nothing else it could be doing other than return either way =)
Comment 4 Martin Robinson 2012-07-19 11:54:45 PDT 
Comment on attachment 153037 [details]
Patch

Good point!
Comment 5 Gustavo Noronha (kov) 2012-07-20 14:41:31 PDT 
Committed r123265: <http://trac.webkit.org/changeset/123265>