WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
91633
[BlackBerry] The blackberry port should not hardcode any default plugin directory
https://bugs.webkit.org/show_bug.cgi?id=91633
Summary
[BlackBerry] The blackberry port should not hardcode any default plugin direc...
Adam Treat
Reported
2012-07-18 09:40:29 PDT
The blackberry port currently hardcodes the directory, '/usr/include/browser/plugins' as its default directory to search. But we have an API for this already which is getApplicationPluginDirectory(). This should be used and no hardcoding should take place. This will allow us to have webviews that do not incur any extra cost for loading the flash plugin for instance when the flash plugin is not necessary.
Attachments
Fix
(2.04 KB, patch)
2012-07-18 09:47 PDT
,
Adam Treat
yong.li.webkit
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Treat
Comment 1
2012-07-18 09:47:07 PDT
Created
attachment 153030
[details]
Fix
Yong Li
Comment 2
2012-07-18 09:51:52 PDT
Comment on
attachment 153030
[details]
Fix canelling
Adam Treat
Comment 3
2012-07-18 09:55:32 PDT
(In reply to
comment #2
)
> (From update of
attachment 153030
[details]
) > canelling
Thanks. Seems our changes for this file haven't been upstreamed yet so this can't apply. Marking as resolved as I'll commit this internally based on your R+ and then it can get upstreamed when the rest of the changes go up for review. Thanks Yong!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug