Bug 91614 - [GTK] Fix a crash due to an invalid assert
Summary: [GTK] Fix a crash due to an invalid assert
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-07-18 04:13 PDT by Carlos Garcia Campos
Modified: 2012-07-18 04:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2012-07-18 04:17 PDT, Carlos Garcia Campos 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-07-18 04:13:57 PDT 
In webkitWebViewBaseContainerAdd() there's ASSERT(priv->inspectorView); that should be the opposite, since we shoulnd't have an inspector view when the inspector view is added.
Comment 1 Carlos Garcia Campos 2012-07-18 04:17:07 PDT 
Created attachment 152985 [details]
Patch
Comment 2 Xan Lopez 2012-07-18 04:19:01 PDT 
Comment on attachment 152985 [details]
Patch

Please add the explanation from comment #1 in the ChangeLog.
Comment 3 WebKit Review Bot 2012-07-18 04:20:52 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Carlos Garcia Campos 2012-07-18 04:27:48 PDT 
(In reply to comment #2)
> (From update of attachment 152985 [details])
> Please add the explanation from comment #1 in the ChangeLog.

Sure, thanks for reviewing.
Comment 5 Carlos Garcia Campos 2012-07-18 04:30:50 PDT 
Committed r122945: <http://trac.webkit.org/changeset/122945>