Bug 91588 – Japanese line breaking rule doesn't work if target character is adjacent to ruby characters

• Status: RESOLVED
• Resolution: CONFIGURATION CHANGED
• Component: Text

[Tatsuya Nitta]

Created attachment 152940 [details]
Test HTML file to reproduce the issue

Overview: 
   If Japanese characters with ruby are adjacent to the target character and the target character is prohibited to place at the end of line or the beginning of the line, the target character can be placed at the prohibited position.

Steps to Reproduce:
  1) Open the attached test file which contains ruby characters("直帰") being adjacent to character("「") which is prohibited to place at the end of line
  2) Drag the resizable corner to resize the window in order to position the character at the end of line
  3) Compare the result between the case of characters with ruby and without ruby

Actual Results: 
  When the target chararcter is adjacent to characters with ruby, line breaking occurs after the character which is prohibited to place at the end of line, 
  or occurs before the character which is prohibited to place at the beginning of line.
  
Expected Results:
  No matter if character is adjacent to characters with ruby, Japanese line breaking rule should work.

Additional Information:
  This occurs no matter what writing direction is, like vertical and horizontal.

[Tatsuya Nitta]

Created attachment 152942 [details]
Screenshot of result in webkit

[Tatsuya Nitta]

Created attachment 153394 [details]
Test HTML file to reproduce the issue

[Tatsuya Nitta]

It's been a while since I logged this bug. It seems there is no update.
Can someone look at this issue?

<rdar://problem/11958427>

[Dan Song]

Only occurred on Mac

[Dan Song]

(In reply to comment #5)
> Only occurred on Mac
Sorry that please ignore this.

[Yuki Sekiguchi]

*** Bug 104645 has been marked as a duplicate of this bug. ***

[Yuki Sekiguchi]

Created attachment 178933 [details]
Patch

[Yuki Sekiguchi]

Created attachment 179852 [details]
Rebase

[Anders Carlsson]

Comment on attachment 179852 [details]
Rebase

Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.

[Dave Hyatt]

Created attachment 245006 [details]
Patch

[WebKit Commit Bot]

Attachment 245006 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBlockFlow.h:461:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebCore/rendering/RenderRubyText.h:50:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Koji Ishii]

FYI, a discussion at www-style
http://lists.w3.org/Archives/Public/www-style/2015Jan/0259.html

[Koji Ishii]

Update: Gecko revised their thoughts and trying to follow the spec. As long as impl are happy, there's no reasons to change the spec.
http://lists.w3.org/Archives/Public/www-style/2015Jan/0403.html

[Jon Lee]

rdar://problem/17306535

[Koji Ishii]

In porting the fix to Blink http://crbug.com/522826, it looks like RenderRubyText::canBreakBefore() checks "prohibit break before" for the previous characters, where it should check "prohibit break after", so it fails OP+ruby case.

A test here (click "Test Case" tab to run):
http://test.csswg.org/shepherd/testcase/line-break-around-ruby-001/name/line-break-around-ruby/

[Ahmad Saleem]

(In reply to Koji Ishii from comment #16)
> In porting the fix to Blink http://crbug.com/522826, it looks like
> RenderRubyText::canBreakBefore() checks "prohibit break before" for the
> previous characters, where it should check "prohibit break after", so it
> fails OP+ruby case.
> 
> A test here (click "Test Case" tab to run):
> http://test.csswg.org/shepherd/testcase/line-break-around-ruby-001/name/line-
> break-around-ruby/

This is also now on WPT.

Blink / Chrome landed this commit: https://src.chromium.org/viewvc/blink?view=revision&revision=201073

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #17)
> (In reply to Koji Ishii from comment #16)
> > In porting the fix to Blink http://crbug.com/522826, it looks like
> > RenderRubyText::canBreakBefore() checks "prohibit break before" for the
> > previous characters, where it should check "prohibit break after", so it
> > fails OP+ruby case.
> > 
> > A test here (click "Test Case" tab to run):
> > http://test.csswg.org/shepherd/testcase/line-break-around-ruby-001/name/line-
> > break-around-ruby/
> 
> This is also now on WPT.
> 
> Blink / Chrome landed this commit:
> https://src.chromium.org/viewvc/blink?view=revision&revision=201073

SVN is gone - https://github.com/chromium/chromium/commit/65c133764c0925fd7baabb58374574c43450b85f

[alan]

IFC (ruby) progression (I remember adding support for it)