Bug 91586 – Build fix for r122870. Comparison of unsigned expression >= 0 is always true.

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Dongseong Hwang]

Build fix for r122870. Comparison of unsigned expression >= 0 is always true.

r122870 is Bug 89039.

[Dongseong Hwang]

Created attachment 152937 [details]
Patch

[Dongseong Hwang]

Debug build failed on Qt with the following text.

MacroExpander.cpp:129:9: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]

[WebKit Review Bot]

Comment on attachment 152937 [details]
Patch

Rejecting attachment 152937 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[Kwang Yul Seo]

(In reply to comment #3)
> (From update of attachment 152937 [details])
> Rejecting attachment 152937 [details] from review queue.
> 
> [e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.
> 
> - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
> 
> - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

Oops. I wanted to land the patch unreviewed because this is a simple build fix. What happens when the flag is r-, cq+?

[Kentaro Hara]

(In reply to comment #4)
> Oops. I wanted to land the patch unreviewed because this is a simple build fix. 

In that case you can land the patch manually by './Tools/Scripts/webkit-patch land'. (If you do not have a committer permission, feel free to ping committers in IRC.)

[WebKit Review Bot]

Comment on attachment 152937 [details]
Patch

Rejecting attachment 152937 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
 patch file(s).
patching file Source/ThirdParty/ANGLE/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp
Hunk #1 FAILED at 126.
1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/13273445

[Dongseong Hwang]

(In reply to comment #5)
> (In reply to comment #4)
> > Oops. I wanted to land the patch unreviewed because this is a simple build fix. 
> 
> In that case you can land the patch manually by './Tools/Scripts/webkit-patch land'. (If you do not have a committer permission, feel free to ping committers in IRC.)

Thank you for kind instruction. I'm not committer, so I'll ping committers. :)

[Dongseong Hwang]

(In reply to comment #6)
> (From update of attachment 152937 [details])
> Rejecting attachment 152937 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2
> 
> Last 500 characters of output:
>  patch file(s).
> patching file Source/ThirdParty/ANGLE/ChangeLog
> Hunk #1 succeeded at 1 with fuzz 3.
> patching file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp
> Hunk #1 FAILED at 126.
> 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.rej
> 
> Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/
> 
> Full output: http://queues.webkit.org/results/13273445

Did I have some mistake about Changelog? I want someone to help.

[Kentaro Hara]

(In reply to comment #8)
> Did I have some mistake about Changelog? I want someone to help.

Looks like this patch is already landed by somebody. Your patch was rejected due to conflict.

[Dongseong Hwang]

(In reply to comment #9)
> (In reply to comment #8)
> > Did I have some mistake about Changelog? I want someone to help.
> 
> Looks like this patch is already landed by somebody. Your patch was rejected due to conflict.

Absolutely, Bug 89039. I'll close this bug as duplicated.

[Dongseong Hwang]

*** This bug has been marked as a duplicate of bug 89039 ***