Bug 91580 - [WK2][EFL] Add a common code using Color instead of QColor
Summary: [WK2][EFL] Add a common code using Color instead of QColor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 22:21 PDT by YoungTaeck Song
Modified: 2012-07-18 03:31 PDT (History)
5 users (show)

See Also:


Attachments
patch (1.63 KB, patch)
2012-07-17 22:21 PDT, YoungTaeck Song
no flags Details | Formatted Diff | Diff
patch (1.63 KB, patch)
2012-07-17 22:28 PDT, YoungTaeck Song
no flags Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2012-07-18 01:55 PDT, YoungTaeck Song
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description YoungTaeck Song 2012-07-17 22:21:25 PDT
Created attachment 152917 [details]
patch

This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation.
drawBorder's argument is QColor. So add a common code using Color to be used by Efl.
Comment 1 WebKit Review Bot 2012-07-17 22:23:58 PDT
Attachment 152917 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 YoungTaeck Song 2012-07-17 22:28:02 PDT
Created attachment 152924 [details]
patch

miss bug number
Comment 3 Simon Hausmann 2012-07-18 00:33:38 PDT
Comment on attachment 152924 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review

> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149
> +#if PLATFORM(QT)
>          textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform);
> +#else
> +        textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform);
> +#endif

I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :)
Comment 4 YoungTaeck Song 2012-07-18 01:55:55 PDT
Created attachment 152962 [details]
Patch
Comment 5 YoungTaeck Song 2012-07-18 01:58:24 PDT
(In reply to comment #3)
> (From update of attachment 152924 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review
> 
> > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149
> > +#if PLATFORM(QT)
> >          textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform);
> > +#else
> > +        textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform);
> > +#endif
> 
> I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :)

Thank you for kind review.
There is no Color::red in Color.h. So I used Color(0xFF, 0, 0).
Comment 6 WebKit Review Bot 2012-07-18 03:31:24 PDT
Comment on attachment 152962 [details]
Patch

Clearing flags on attachment: 152962

Committed r122941: <http://trac.webkit.org/changeset/122941>
Comment 7 WebKit Review Bot 2012-07-18 03:31:29 PDT
All reviewed patches have been landed.  Closing bug.